Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add a config option to only ride (tamable mobs) if they are tamed. #56

Closed
AZFire1 opened this issue Sep 9, 2020 · 3 comments

Comments

@AZFire1
Copy link

AZFire1 commented Sep 9, 2020

Sorry for yet another feature request, though I just have many ideas and wanted to share.

Feature Description:
There could be a configurable option that is added per tamable mob which could be called "ridable-only-if-tamed" to allow riding mobs only if they are tamed. This could be useful (for example), if you wanted to restrict players from riding wolves/moving them somewhere if they haven't tamed them yet. Not sure if it's "needed" though. It's up to you.

@jpenilla
Copy link
Contributor

jpenilla commented Sep 9, 2020

I think what they are asking for is actually a bit different. I think what they want is for this line to be changed from
if (tameable.isTamed() && !tameable.isOwner(entityhuman)) {
to
if (!tameable.isTamed() || !tameable.isOwner(entityhuman)) {

I tested myself, and right now I can ride a wild wolf, or my own wolf, but I cannot ride a wolf tamed by another player. The requested behavior is that you can only ride the wolf if you have tamed it yourself. This could maybe be a config option for all tamable mobs, or a toggle for each? There are a couple different ways this could be implemented, but I don't think it's a bad idea.

@BillyGalbreath BillyGalbreath reopened this Sep 9, 2020
@AZFire1
Copy link
Author

AZFire1 commented Sep 9, 2020

Correct, yes that's what I meant jmanpenilla.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants