Do not match directory that begins with ._, only files. #260

plack · Oct 19, 2012 · c2b3646 · c2b3646
1 parent ecb3a36
commit c2b3646
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/lib/Plack/Loader/Restarter.pm b/lib/Plack/Loader/Restarter.pm
@@ -3,6 +3,7 @@ use strict;
 use warnings;
 use parent qw(Plack::Loader);
 use Plack::Util;
+use File::Basename;
 use Try::Tiny;
 
 sub new {
@@ -46,7 +47,7 @@ sub _kill_child {
 
 sub valid_file {
     my($self, $file) = @_;
-    $file->{path} !~ m![/\\][\._]|\.bak$|~$|_flymake\.p[lm]!;
+    File::Basename::basename($file->{path}) !~ m!^[\._]|\.bak$|~$|_flymake\.p[lm]!;
 }
 
 sub run {

diff --git a/t/Plack-Loader/restarter_valid.t b/t/Plack-Loader/restarter_valid.t
@@ -0,0 +1,15 @@
+use strict;
+use Plack::Loader::Restarter;
+use Test::More;
+
+my $r = Plack::Loader::Restarter->new;
+
+my @match  = qw(Foo.pm foo.t lib/Bar.pm view/index.tt _myapp/foo.psgi /Users/joe/foo/bar.pm);
+my @ignore = qw(.xxx Foo.pm~ _flymake.pl foo/.bar.pm /Users/joe/foo.pl~);
+
+ok $r->valid_file({ path => $_ }), "$_ is valid" for @match;
+ok !$r->valid_file({ path => $_ }), "$_ should be ignored" for @ignore;
+
+done_testing;
+
+