-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP::Server::PSGI crash when header value is utf8 string #353
Comments
This is a violation of the PSGI specification and it is a responsibility of apps or frameworks to encode it in utf8 or whatever byte strings, and could be detected with Lint middleware which is enabled by default under development environment. |
@miyagawa It actually isn't a violation as written currently - the PSGI specification states that the body must be encoded, but doesn't say anything about the headers. This should probably be clarified in the spec. |
Good catch. Should be addressed in the PSGI spec then. |
There is a crash even with Lint middleware enabled (-E development) |
Does it worth to cover this case in Lint middleware, similar to existing check you mentioned? Something similar to this check: https://metacpan.org/source/MIYAGAWA/Plack-1.0013/lib/Plack/Middleware/Lint.pm#L155 |
Yeah, Lint could probably check that as well, once we clarify it in the PSGI spec. I've been wondering if it's worth adding the |
I think covering it in Lint is probably sufficient - everything else is supposed to be able to just assume valid PSGI, isn't it? If fixing it in HTTP::Server::PSGI is actually important, seems like sticking the |
Yeah, everyone else can assume it's valid PSGI, and there's no need for individual servers to deal with it. I just thought this crash is pretty severe, given that if this were a plain But if a patch can be made to work with eval/catch that'd probably be better. (I have no idea why |
#429 also fixed that issue |
Yep, fixed by #429 |
$ plackup -E deployment -s HTTP::Server::PSGI -e 'sub {[200,[x=>"\x{100}"],[""]]}' &
$ curl http://127.0.0.1:5000/
Wide character in syswrite at /usr/lib64/perl5/IO/Handle.pm line 478.
curl: (52) Empty reply from server
[1] + exit 255 plackup -E deployment -s Standalone -e 'sub {[200,[x=>"\x{100}"],[""]]}'
The text was updated successfully, but these errors were encountered: