Encode strings as UTF-8 when it has wide characters #429
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been controversial for so long, and my canned response is that an app returning data that breaks PSGI specification is ok to break, and should these kind of errors be handled by Lint in the development.
Meanwhile, a) realistically it's not cool for app mistakes to be able to crash servers and b) if some of these PSGI violation only happens sometimes in the runtime, catching them with Lint might be difficult as well.
There should always be a line drawn, since there are many other ways to break HTTP::Server::PSGI as well by returning (for example) a hash for headers instead of arrays, and handling all of these mistakes in the server isn't realistic (and could make the server slow).
This should probably be documented as part of the spec or guideline, but here's a quick fix on the reference server to catch such errors.