Little fix for some weird cookie string like Google Analytics #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix is for some weird cookie string like '__utmv=XXXXXXX.|4=k4=false=1,;' that is used Google Analytics.
|
Nice - can you add a unit test for this? |
|
I thought you'd say that :) |
|
I've committed test too! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some weird cookie string like '__utmv=XXXXXXX.|4=k4=false=1,;' and this caused following warnings:
Use of uninitialized value $key in exists at /home/homepage/perl5/perlbrew/perls/5.12.1/lib/site_perl/5.12.1/Plack/Request.pm line 78.
Use of uninitialized value $key in hash element at /home/homepage/perl5/perlbrew/perls/5.12.1/lib/site_perl/5.12.1/Plack/Request.pm line 78.
This little commit is for avoiding this warnings.