Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 198 prop type and docs #199

Merged
merged 7 commits into from Oct 5, 2020
Merged

Fix 198 prop type and docs #199

merged 7 commits into from Oct 5, 2020

Conversation

prometheas
Copy link
Contributor

Addresses issue #198.

@prometheas
fix: correct prop type declaration
1d3de75
@prometheas
docs: add key detail for using custom component prop
cb9adb0 
The docs fail to mention that whatever component is supplied to the `component` prop must support an `onPress` callback prop in order to function.
@prometheas
docs: add info about requirements for optional component prop
f79dc8f 
Using a custom `component` prop only works when the specified custom component type itself accepts an `onPress` callback prop.
@prometheas
docs(README): improve code blocks
2263b1d 
Added language hints to the fenced code blocks missing them to introduce syntax coloring when Github renders them.  Also fixed some parse errors in JS blocks, and small whitespace tweaks.
@prometheas
docs: add missing import from onEvent callbacks code block
32ab2db
@prometheas
Copy link
Contributor Author

Hey gang. I've opened up a support ticket, too, but I'd really like to get rid of that incorrect proptype warning at the bottom of my simulator. It's not a good look for our demos 😉

amytang0
amytang0 previously approved these changes Oct 5, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
amytang0
amytang0 reviewed Oct 5, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
amytang0
amytang0 approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@amytang0 amytang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Prometheas, thank you so much for putting out this PR!
I changed some of the README.md around the token field, but otherwise LGTM

@amytang0 amytang0 merged commit 779891d into plaid:master Oct 5, 2020
@prometheas
Copy link
Contributor Author

image

@prometheas
Copy link
Contributor Author

Any guidance as to when this fix will go out to npm?

@cb-aaron cb-aaron mentioned this pull request Oct 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amytang0 amytang0 amytang0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prometheas @amytang0