Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 198 prop type and docs #199

Merged
merged 7 commits into from
Oct 5, 2020
Merged

Fix 198 prop type and docs #199

merged 7 commits into from
Oct 5, 2020

Commits on Oct 1, 2020

  1. fix: correct prop type declaration

    @prometheas
    prometheas committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    1d3de75 View commit details
    Browse the repository at this point in the history

  2. docs: add key detail for using custom component prop 

    The docs fail to mention that whatever component is supplied to the `component` prop must support an `onPress` callback prop in order to function.
    @prometheas
    prometheas committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    cb9adb0 View commit details
    Browse the repository at this point in the history

  3. docs: add info about requirements for optional component prop 

    Using a custom `component` prop only works when the specified custom component type itself accepts an `onPress` callback prop.
    @prometheas
    prometheas committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    f79dc8f View commit details
    Browse the repository at this point in the history

  4. docs(README): improve code blocks 

    Added language hints to the fenced code blocks missing them to introduce syntax coloring when Github renders them.  Also fixed some parse errors in JS blocks, and small whitespace tweaks.
    @prometheas
    prometheas committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    2263b1d View commit details
    Browse the repository at this point in the history

  5. docs: add missing import from onEvent callbacks code block

    @prometheas
    prometheas committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    32ab2db View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2020

  1. Update README.md

    @amytang0
    amytang0 committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    bfea140 View commit details
    Browse the repository at this point in the history

  2. Update README.md

    @amytang0
    amytang0 committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    0c417bd View commit details
    Browse the repository at this point in the history