Replace existing localization system with Transifex Native #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
area363,
boscohyun,
dahlia,
limebell,
longfin,
moreal and
riemannulus
|
Oh right, before merging this please make sure to put Transifex API keys to GitHub secrets. Without it the action will not be able to update translations! |
longfin
reviewed
Jun 21, 2021
riemannulus
reviewed
Jun 21, 2021
riemannulus
approved these changes
Jun 23, 2021
This isn't ideal, but it seemed like a nice compromise.
POTENTIALLY BREAKING: 9c may get unsupported language code if the system locale is unsupported.
Co-authored-by: Lee, Suho <riemannulus@hitagi.moe>
|
PTAL @longfin 🙏 |
longfin
approved these changes
Jun 23, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to replace all the existing useLocale calls to appropriate Transifex Native API calls. However there are some pitfalls, mainly multiple string entries being replaced to simple multiline strings.
Note that this PR is pretty much WIP, and there are major issues to be resolved before merging this into upstream.
Find a way to use current API with Monster Collections system.Postponed.