Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design]UI_Summon_Prefabs_Edit / 레드소환 #4844

Merged
merged 16 commits into from
May 16, 2024

Conversation

boramqo83
Copy link
Contributor

@boramqo83 boramqo83 commented Apr 24, 2024

Description

ui/red_aura_rune-add

Related Links

https://github.com/orgs/planetarium/projects/97/views/8?pane=issue&itemId=60779969

2024-05-15.17-44-23.mp4

위 영상처럼 레드소환을 추가합니다.

  • 레드소환 전용 UI, 영상 리소스가 추가됩니다
  • 재화창에서 3개의 메터리얼을 표시해주는 경우 NCG표시 대신 필요 메터리얼만 표시해주도록 재화 UI를 변경합니다
  • 레드소환 UI에 임시 l10n 텍스트키를 적용해두었습니다.

@boramqo83 boramqo83 linked an issue Apr 24, 2024 that may be closed by this pull request
@eugene-doobu eugene-doobu marked this pull request as draft April 29, 2024 02:13
@eugene-doobu eugene-doobu self-assigned this Apr 29, 2024
@eugene-doobu eugene-doobu changed the title [Design]UI_Summon_Prefabs_Edit [Design]UI_Summon_Prefabs_Edit / 레드소환 May 13, 2024
@eugene-doobu eugene-doobu marked this pull request as ready for review May 13, 2024 05:48
@eugene-doobu eugene-doobu requested a review from a team as a code owner May 13, 2024 05:48
@tyrosine1153
Copy link
Contributor

tyrosine1153 commented May 13, 2024

제목과 설명(여기) 채워주시면 감사하겠습니다.

  • 스크린샷이나 실행 영상도 가능하면 첨부해주세요😊

Copy link
Contributor

@tyrosine1153 tyrosine1153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😊👍💯

Comment on lines +5 to +18
public static int GetBackGroundPosition(CostType grade)
{
switch (grade)
{
case CostType.SilverDust:
return 690;
case CostType.GoldDust:
return 0;
case CostType.RubyDust:
return -690;
default:
return 0;
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetDrawButton 처럼 Summon 안에만 있어도 상관없을 것 같습니다. (선택입니당)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SummonUI 뿐만 아니라 SummonResultPopup에서도 사용해서 별도로 분리시켜놨습니다

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 이걸 이렇게 쓰네... 확인 감사합니다

@eugene-doobu
Copy link
Member

제목과 설명(여기) 채워주시면 감사하겠습니다.

  • 스크린샷이나 실행 영상도 가능하면 첨부해주세요😊

실행 영상과 간략한 설명 추가했습니다.

@eugene-doobu eugene-doobu merged commit ff065ae into development May 16, 2024
2 checks passed
@eugene-doobu eugene-doobu deleted the ui/red_aura_rune-add branch May 16, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

레드 소환
3 participants