Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix improper timeout cancellation for ProcessRequest() in NetMQTransport #1734

Closed
greymistcube opened this issue Jan 19, 2022 · 0 comments · Fixed by #1789
Closed

Fix improper timeout cancellation for ProcessRequest() in NetMQTransport #1734

greymistcube opened this issue Jan 19, 2022 · 0 comments · Fixed by #1789
Assignees

Comments

@greymistcube
Copy link
Contributor

Given a TimeSpan for timeout when processing a MessageRequest, timeout is handled improperly. Instead of tying the given TimeSpan to the process, the given TimeSpan is tied to each network communication. For instance, if a timeout of 5 seconds is provided for sending some message and expecting 10 replies, instead of timing the combined process of sending and receiving all replies, the current implementation can wait up to 5 seconds for sending the message and 5 seconds each for each reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant