You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Several interfaces store a bitmask of addresses into Address type. This leads to misunderstand these values are a valid address, which is not true.
Although the WildcardMask constant is defined, but it is placed in an inappropriate place: BlockSet<T>. It should be treated like AddressMask.Wildcard instead.
Matching algorithm is also placed in a random place. It should be abstracted out like IsPossiblyIn(this Address, AddressMask) or IsDefinitelyNotIn(this Address, AddressMask).
Adding an Address into a bitmask is also placed in a random place. It should be abstracted out like AddressMask.Add(Address).
The text was updated successfully, but these errors were encountered:
Continued from the patch #197.
Problems:
Address
type. This leads to misunderstand these values are a valid address, which is not true.WildcardMask
constant is defined, but it is placed in an inappropriate place:BlockSet<T>
. It should be treated likeAddressMask.Wildcard
instead.IsPossiblyIn(this Address, AddressMask)
orIsDefinitelyNotIn(this Address, AddressMask)
.Address
into a bitmask is also placed in a random place. It should be abstracted out likeAddressMask.Add(Address)
.The text was updated successfully, but these errors were encountered: