Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distinguish the starting stage of Swarm clearly #735

Closed
moreal opened this issue Dec 18, 2019 · 0 comments · Fixed by #760
Closed

Distinguish the starting stage of Swarm clearly #735

moreal opened this issue Dec 18, 2019 · 0 comments · Fixed by #760
Labels
suggestion Suggestion or feature request

Comments

@moreal
Copy link
Contributor

moreal commented Dec 18, 2019 •
edited

Swarm<T>.PreloadAsync() is a method to download blocks preemptively. After preloading, we should call Swarm<T>.StartAsync() to synchronize the blockchain periodically, then Swarm<T> starts to receive blocks and synchronize the blockchain periodically.

But now, PreloadAsync() is called from StartAsync() one more time, to receive blocks created during preloading. So IMO they should be distinguished clearly by making StartAsync() not to call PreloadAsync(), to ensure each functions.
@moreal moreal added the suggestion Suggestion or feature request label Dec 18, 2019
@moreal moreal mentioned this issue Jan 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
suggestion Suggestion or feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Distinguish the starting stages of Swarm clearly moreal/libplanet
1 participant
@moreal