Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distinguish the starting stages of Swarm clearly #760

Merged
merged 3 commits into from Jan 16, 2020
Merged

Distinguish the starting stages of Swarm clearly #760

merged 3 commits into from Jan 16, 2020

Conversation

moreal
Copy link
Contributor

@moreal moreal commented Jan 14, 2020

It resolves #735.

@moreal moreal force-pushed the remove-preloading-in-start-async branch 2 times, most recently from 01254a0 to 8220efe Compare January 15, 2020 05:20
@moreal moreal self-assigned this Jan 15, 2020
@codecov
Copy link

codecov bot commented Jan 15, 2020 •
edited

Codecov Report

Merging #760 into master will decrease coverage by 0.01%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##           master     #760      +/-   ##
==========================================
- Coverage   86.36%   86.34%   -0.02%     
==========================================
  Files         223      223              
  Lines       19179    19157      -22     
==========================================
- Hits        16563    16541      -22     
+ Misses       1410     1409       -1     
- Partials     1206     1207       +1
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 85.84% <100%> (-0.03%) ⬇️
Libplanet.Tests/Net/SwarmTest.cs 96.12% <75%> (ø) ⬆️
Libplanet/Crypto/PrivateKey.cs 85.34% <0%> (-0.87%) ⬇️
Libplanet/Net/NetMQTransport.cs 76.83% <0%> (-0.29%) ⬇️

@limebell
Copy link
Member

I guess PreloadAsync's render parameter is not used. Can we remove it?

longfin
longfin previously approved these changes Jan 15, 2020
View reviewed changes
@moreal moreal force-pushed the remove-preloading-in-start-async branch from 8220efe to 53fe205 Compare January 15, 2020 09:49
@moreal
Copy link
Contributor Author

moreal commented Jan 15, 2020

I guess PreloadAsync's render parameter is not used. Can we remove it?

Yes, I applied it. Review again please 😁 @limebell

@moreal moreal requested a review from longfin January 16, 2020 01:41
@moreal moreal merged commit 46b6fba into planetarium:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longfin longfin longfin approved these changes

@limebell limebell limebell approved these changes

@earlbread earlbread earlbread approved these changes

@dahlia dahlia Awaiting requested review from dahlia

Assignees

@moreal moreal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Distinguish the starting stage of Swarm clearly
4 participants
@moreal @limebell @longfin @earlbread