Would TxId be better if it inherits HashDigest<SHA256>?

[dahlia]

Since TxId is a SHA-256 digest, the most of things are in common with HashDigest<SHA256>. Would TxId be better to inherit HashDigest<256>? Or, rather, would it be fine even if we get rid of TxId at all and replace them with HashDigest<256>?

[longfin]

I think considering TxId as HashDigest<SHA256> makes sense. but it also means that we allow to assign TxId to any HashDigest<SHA256> fields (e.g. Block.Hash). it can be quite fragile.

So, I suggest to make some other concrete type for these type like BlockHash to distinguish among them if we want to use inheritance.

[dahlia]

Having a distinct type for each BlockHash and TxId and they inheriting HashDigest<SHA256> seems good.

[qria]

I call dibs on this issue

[qria]

HashDigest<T> was a struct not class so inheritance is not possible. what do?

[dahlia]

@qria You're right. The idea in itself seems invalid.

[qria]

I no longer am working on this until there's a new idea for this.

[longfin]

I'll close this issue until we have a new idea to address this issue.