New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export all states as JSON #1026
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moreal
added
storage
Related to storage (Libplanet.Store)
tools
Related to CLI tools (Libplanet.Tools)
labels
Oct 6, 2020
moreal
force-pushed
the
feature/export-trie-states
branch
from
October 8, 2020 11:04
81f23bc
to
e82a9de
Compare
Codecov Report
@@ Coverage Diff @@
## main #1026 +/- ##
==========================================
+ Coverage 88.43% 88.45% +0.02%
==========================================
Files 334 335 +1
Lines 30341 30401 +60
==========================================
+ Hits 26831 26891 +60
+ Misses 1902 1899 -3
- Partials 1608 1611 +3
|
moreal
force-pushed
the
feature/export-trie-states
branch
2 times, most recently
from
October 12, 2020 02:16
759b3bb
to
e4ce480
Compare
/rebase |
moreal
force-pushed
the
feature/export-trie-states
branch
from
October 13, 2020 04:47
e4ce480
to
cced969
Compare
auto-assign
bot
requested review from
dahlia,
earlbread,
limebell,
longfin and
riemannulus
October 13, 2020 04:48
limebell
previously approved these changes
Oct 14, 2020
longfin
previously approved these changes
Oct 14, 2020
earlbread
previously approved these changes
Oct 14, 2020
moreal
force-pushed
the
feature/export-trie-states
branch
from
October 14, 2020 09:11
cced969
to
b9774be
Compare
moreal
force-pushed
the
feature/export-trie-states
branch
from
October 14, 2020 09:11
b9774be
to
2aa5a6c
Compare
There was a problem about compile in mono because of the difference between netcoreapp2.2 and netstandard2.0. I fixed it. Please review again 🙏 cc @longfin @earlbread @limebell |
earlbread
approved these changes
Oct 14, 2020
limebell
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this pull request, #1023 MUST proceed.
This pull request introduced a new feature to export all states corresponded to the state root hash as JSON.
Usage
Export format
It will be exported as not pretty JSON like the below type: