Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use protocol version of existing block #1162

Merged
merged 2 commits into from Jan 15, 2021

Conversation

moreal
Copy link
Contributor

@moreal moreal commented Jan 15, 2021

SSIA.

@moreal moreal added the bug Something isn't working label Jan 15, 2021
@moreal moreal self-assigned this Jan 15, 2021
longfin
longfin previously approved these changes Jan 15, 2021
@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #1162 (605cb5b) into main (cd982b6) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1162      +/-   ##
==========================================
+ Coverage   87.54%   87.59%   +0.05%     
==========================================
  Files         350      350              
  Lines       30475    30488      +13     
==========================================
+ Hits        26678    26706      +28     
+ Misses       2100     2083      -17     
- Partials     1697     1699       +2     
Impacted Files Coverage Δ
Libplanet.Tests/Store/StoreTest.cs 98.48% <100.00%> (+0.03%) ⬆️
Libplanet/Store/BaseStore.cs 78.04% <100.00%> (+0.54%) ⬆️
Libplanet.Tests/Net/SwarmTest.Preload.cs 99.00% <0.00%> (-0.29%) ⬇️
Libplanet/Net/Protocols/KademliaProtocol.cs 79.00% <0.00%> (+0.39%) ⬆️
Libplanet/Net/Swarm.cs 82.59% <0.00%> (+0.95%) ⬆️
Libplanet/Net/Protocols/KBucket.cs 94.06% <0.00%> (+2.54%) ⬆️

Copy link
Contributor

@dahlia dahlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a link to this pull request on the relevant changelogs?

libplanet/CHANGES.md

Lines 11 to 14 in cd982b6

- Added the parameter `protocolVersion` to `Block<T>(long, long, BigInteger,
Nonce, Address?, HashDigest<SHA256>?, DateTimeOffset,
IEnumerable<Transaction<T>> transactions, HashDigest<SHA256>?,
HashDigest<SHA256>?)` constructor. [[#1142], [#1147]]

libplanet/CHANGES.md

Lines 99 to 102 in cd982b6

- Introduced the [protocol versioning scheme][#1142]. This purposes to change
the protocol without breaking backward compatibility. Even the protocol
is changed, the existing blocks made before the new protocol are guaranteed
to behave as it had done. [[#1142], [#1147]]

dahlia
dahlia previously approved these changes Jan 15, 2021
CHANGES.md Outdated Show resolved Hide resolved
@moreal moreal requested a review from longfin January 15, 2021 04:59
Copy link
Member

@riemannulus riemannulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@longfin longfin merged commit 579c698 into planetarium:main Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants