Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance KademliaProtocol.BootstrapAsync() #1219

Merged
merged 3 commits into from Apr 8, 2021

Conversation

limebell
Copy link
Member

This patch fixes a bug where protocol has been pinged to peers that were already pinged. Additionally, fixes duplicated cache updates.

@limebell limebell self-assigned this Mar 29, 2021
longfin
longfin previously approved these changes Mar 29, 2021
moreal
moreal previously approved these changes Mar 30, 2021
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #1219 (b306792) into main (05b537f) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

❗ Current head b306792 differs from pull request most recent head e7c3573. Consider uploading reports for the commit e7c3573 to get more accurate results

@@            Coverage Diff             @@
##             main    #1219      +/-   ##
==========================================
- Coverage   86.01%   86.00%   -0.02%     
==========================================
  Files         361      361              
  Lines       32505    32523      +18     
==========================================
+ Hits        27960    27972      +12     
- Misses       2762     2767       +5     
- Partials     1783     1784       +1     
Impacted Files Coverage Δ
Libplanet/Net/Protocols/KademliaProtocol.cs 67.41% <75.00%> (+0.55%) ⬆️
Libplanet/Net/Protocols/KBucket.cs 87.17% <0.00%> (-7.70%) ⬇️
Libplanet/Hashcash.cs 94.44% <0.00%> (-5.56%) ⬇️
Libplanet.Tests/Net/Protocols/TestTransport.cs 74.31% <0.00%> (-0.62%) ⬇️
Libplanet/Net/NetMQTransport.cs 79.53% <0.00%> (+1.31%) ⬆️

@limebell limebell dismissed stale reviews from moreal and longfin via 242efee March 31, 2021 04:45
Copy link
Member

@riemannulus riemannulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need a changelog if this PR fixes some bug.

riemannulus
riemannulus previously approved these changes Apr 5, 2021
@riemannulus riemannulus self-requested a review April 8, 2021 08:53
@limebell limebell merged commit 268d68c into planetarium:main Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants