IStore.ListNamespaces() method #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earlbread
previously approved these changes
Mar 21, 2019
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
==========================================
- Coverage 87.68% 84.95% -2.74%
==========================================
Files 69 69
Lines 3241 3250 +9
==========================================
- Hits 2842 2761 -81
- Misses 399 489 +90
|
longfin
previously approved these changes
Mar 21, 2019
|
@longfin @earlbread I rebased this on the current master and added a changelog too. Could you review this again? |
earlbread
approved these changes
Mar 21, 2019
dahlia
pushed a commit
to dahlia/libplanet
that referenced
this pull request
Mar 9, 2021
…Microsoft.NET.Test.Sdk-16.8.3 Bump Microsoft.NET.Test.Sdk from 15.9.0 to 16.8.3
OnedgeLee
pushed a commit
to OnedgeLee/libplanet
that referenced
this pull request
Jan 31, 2023
…anifests-1669359664 Update internal manifests [update-internal-manifests-1669359664]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although I frankly am not sure if it's really necessary, I added a new method
ListNamespaces()toIStoreand implementedFileSystem.ListNamespaces()too. I am going to use this to make an ad-hoc solution to #96.