Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Swarm<T>.MaintainStaticPeersAsync() throwing PingTimeoutException #1551

Merged
merged 1 commit into from Oct 26, 2021

Conversation

dahlia
Copy link
Contributor

@dahlia dahlia commented Oct 26, 2021

This fixes #1550.

@dahlia dahlia added bug Something isn't working network Related to networking (Libplanet.Net) ci & cd Related to CI & CD on Azure Pipelines & GitHub Actions labels Oct 26, 2021
@dahlia dahlia requested a review from limebell October 26, 2021 02:19
@dahlia dahlia self-assigned this Oct 26, 2021
@dahlia dahlia added this to In progress in v100083 via automation Oct 26, 2021
@dahlia dahlia added this to In progress in Libplanet via automation Oct 26, 2021
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #1551 (3736e1d) into main (2e80048) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1551      +/-   ##
==========================================
- Coverage   26.76%   26.74%   -0.02%     
==========================================
  Files         279      279              
  Lines       18172    18176       +4     
==========================================
- Hits         4863     4861       -2     
- Misses      12931    12937       +6     
  Partials      378      378              
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 0.00% <0.00%> (ø)
Libplanet.RocksDBStore/RocksDBStore.cs 79.12% <0.00%> (-0.26%) ⬇️

Libplanet automation moved this from In progress to Reviewer approved Oct 26, 2021
@dahlia dahlia merged commit e555137 into planetarium:main Oct 26, 2021
Libplanet automation moved this from Reviewer approved to Done Oct 26, 2021
v100083 automation moved this from In progress to Done Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci & cd Related to CI & CD on Azure Pipelines & GitHub Actions network Related to networking (Libplanet.Net)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

SwarmTest.MaintainStaticPeers occasionally fails due to PingTimeoutException
2 participants