Bad tip expiration for pulling blocks fix #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
reviewed
Nov 25, 2021
| @@ -155,11 +155,11 @@ CancellationToken cancellationToken | |||
| lastUpdated = DateTimeOffset.UtcNow; | |||
| lastTip = BlockChain.Tip; | |||
| } | |||
| else if (lastUpdated + tipLifespan > DateTimeOffset.UtcNow) | |||
| else if (lastUpdated + tipLifespan < DateTimeOffset.UtcNow) | |||
There was a problem hiding this comment.
Would it be difficult to add a regression test for this bug?
There was a problem hiding this comment.
Well, it's probably possible to do a unit test by elevating the access level to internal and directly calling the method, but I'm not sure about a regression test. 😗
greymistcube
force-pushed
the
bugfix/tip-expiration
branch
2 times, most recently
from
6513a00
to
2800e02
Compare
greymistcube
force-pushed
the
bugfix/tip-expiration
branch
from
2800e02
to
e051177
Compare
dahlia
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inequality inside
Swarm<T>.PollBlocksAsync()determining whether tip has become stale was set up to act oppositely to what was intended. This would've resulted in not polling properly once tip has actually gone stale unless tip is changed by a push from another node.Also, changed the polling interval to
60seconds.