Improve performance of BlockChain<T>.FindNextHashes()
#1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
force-pushed
the
feature/improve-store-iterateindex
branch
2 times, most recently
from
2d158b0
to
6f51e94
Compare
longfin
force-pushed
the
feature/improve-store-iterateindex
branch
from
6f51e94
to
c2af9bb
Compare
auto-assign
bot
requested review from
dahlia,
greymistcube,
limebell and
riemannulus
riemannulus
previously approved these changes
Dec 17, 2021
Co-authored-by: Say Cheong <greymistcube@gmail.com>
greymistcube
approved these changes
Dec 17, 2021
limebell
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves performance of
BlockChain<T>.FindNextHashes()through two bellow adjustments._rwlockfromBlockChain<T>.FindNextHashes()because it has already protected by another lock onBlockChain<T>.FindBranchpoint().RocksDBStore.IterateIndexes()to speed up iterative lookups.