Change the way how TxCompletion<TPeer, TAction> fetch transaction from other peers
#1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| })); | ||
|
|
||
| var validTxs = new List<Transaction<TAction>>(); | ||
| IImmutableSet<TxId> stagedTxIds = _blockChain.GetStagedTransactionIds(); |
There was a problem hiding this comment.
BlockChain<T>.StageTransaction() should do the job of filtering so no additional filtering is necessary at this point. See #1648.
There was a problem hiding this comment.
Eh, then again, we can't count validTxs if we don't do the filtering here. I'll create an issue for this.
There was a problem hiding this comment.
So you mean L158 to L176 is not required and just
foreach (var tx in txs)
{
try
{
_blockChain.StageTransaction(tx);
}
catch (InvalidTxException ite)
{
const string msg = "Received transaction from {Peer} with id {TxId} " +
"will not be staged since it is invalid.";
_logger.Error(ite, msg, peer, tx.Id);
}
}
will do the work?
There was a problem hiding this comment.
I'll deal with this in #1705.
There was a problem hiding this comment.
IStagePolicy is designed not to throw any Exception so yes, I think it should be fine.
There was a problem hiding this comment.
But yeah, since broadcasting is tied to validTxs, I think it should be left as it is for now.
longfin
previously approved these changes
Jan 11, 2022
greymistcube
requested changes
Jan 11, 2022
Co-authored-by: Say Cheong <greymistcube@gmail.com>
limebell
force-pushed
the
feature/txcompletion-spawn-task
branch
from
7a520fd
to
280aae2
Compare
greymistcube
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
TxCompletion<TPeer, TAction>.RequestTxsFromPeerAsync()is maintained maximum 1 task for each peer to fetch transactions from. It caused a bug where fetching does not working even received a newTxIds from other peer.This PR force to spawn
TxCompletion<TPeer, TAction>.RequestTxsFromPeerAsync()task every time newTxIds are received.