New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
BootstrapOptions
added to SwarmOptions
#2024
BootstrapOptions
added to SwarmOptions
#2024
Conversation
Default removed from searchDepth
85af3bb
to
831c2b5
Compare
@@ -370,6 +371,7 @@ private static BlockPolicy<T> LoadBlockPolicy<T>(Options options) | |||
await swarm.BootstrapAsync( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about using newly introduced Swarm<T>.BootstrapAsync(CancellationToken)
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. See 7e5fe07. We probably need to overhaul Program.cs
at some point. 馃檭
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 馃憤 聽:ok_hand: 聽:thumbsdown: (Email) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃憤
Mainly to reduce clutter on higher layers. 馃樁
This intermediary
SwarmOptions
seems quite untidy at the moment, but it'll get better soon after I addPreloadOptions
. 馃槜