-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added GraphQL type descriptions #2074
Conversation
[skip changelog]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Akamig Sadly, the build is failing. 😢there are two main reasons.
- Lint is complaining "Line must be no longer than 100 characters"
StandaloneSchema
needs a type argumentT
.
- but... I don't have confidence about
StandaloneSchema
itself. (because I guess it's too ambigus naming) - how about opening another PR for Provide
Schema
object instead ofQuery
s #2065 ?
@longfin
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Akamig Oops, lint is now complaining that "The parameter spans multiple lines". 😢
I guess it would be better checking dotnet build
on your local env before commit & push. 🙏
Maybe should I shorten description to fit under 100 characters? |
It seems that make sense. then, disabling lint using |
Co-authored-by: Swen Mun <longfinfunnel@gmail.com>
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
This PR resolves #1247, and "Tried but failed" to mediate #2065, but failed due to Generics of each queries in explorer.
Is there any good Idea to circumvent each IActions required by all queries?