New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Prevent improper parsing on 'Uri.UserInfo' with exception #2116
fix: Prevent improper parsing on 'Uri.UserInfo' with exception #2116
Conversation
First CI Test on |
Do I have to update |
I'll try to track test failure case, and raise an issue if it's needed |
libplanet/Libplanet.Net/IceServer.cs Line 19 in 6146ed4
This comment should be removed. 😗 |
Should be added under |
36cbbec
to
c27e6f5
Compare
656f7c4
to
37786a4
Compare
|
37786a4
to
2cd08c4
Compare
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Rebased onto |
Changes
Related issue
:
s inUri
forIceServer
#2058