New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port/0.45.4 & remove workers
option for NetMQTransport
#2690
Conversation
* Prepare 0.45.4 * Update CHANGES.md Co-authored-by: Say Cheong <greymistcube@gmail.com> Co-authored-by: Say Cheong <greymistcube@gmail.com>
Fix bugs and stabilize unit test again
Release 0.44.7
Libplanet 0.44.7
Port 0.44.7 & Release 0.45.4
worker
option for NetMQTransport
workers
option for NetMQTransport
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2690 +/- ##
==========================================
+ Coverage 80.72% 80.75% +0.03%
==========================================
Files 301 301
Lines 10410 10440 +30
==========================================
+ Hits 8403 8431 +28
- Misses 2007 2009 +2
|
d802f37
to
7501f2a
Compare
a955949
to
b0ee61f
Compare
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
This PR mainly aims to port the changes from #2684. also, it drops
workers
options no longer necessary, fromNetMQ Transport.CreateAsync()
,And more, I tried a few test stabilizations but failed as a result. In particular, socket errors occur very often on macOS, which will be covered in another PR.