New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize/deserialize Block<T>
better with System.Text.Json.JsonSerializer
#2756
Conversation
29f71bc
to
12b2661
Compare
12b2661
to
3681320
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2756 +/- ##
==========================================
- Coverage 80.45% 80.45% -0.01%
==========================================
Files 307 309 +2
Lines 10579 10604 +25
==========================================
+ Hits 8511 8531 +20
- Misses 2068 2073 +5
|
https://github.com/planetarium/libplanet/actions/runs/4023856396/jobs/6915215674 Could you check this CI? |
3681320
to
eca54bb
Compare
@riemannulus I addressed the issue. Could you take a look again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just typos.
[changelog skip]
[changelog skip]
eca54bb
to
a084468
Compare
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
@moreal All addressed. Please take a look one more tine. /cc @riemannulus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Implemented
JsonConverter
forBlock<T>
and its fields. Here's a sample block encoded into JSON: