New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Removed nullability from TrustedAppProtocolVersionSigners
#2759
Conversation
3596c9e
to
bc1ddc5
Compare
TrustedAppProtocolVersionSigners
1ac4748
to
7564bc4
Compare
7564bc4
to
43a3ebb
Compare
43a3ebb
to
d62f8fd
Compare
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree
Several points:
null
s are bad in general if they can be avoided.null
option isn't really being used.null
and empty list as meaningful options are incompatible with current CLI.If
null
is still that important, we should change the CLI to accept a formattedstring
to allow all possible cases. 🙄