New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make PolymorphicAction<T>._actionTypeLoader
configurable
#2873
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add changelog for it?
1ffc62c
to
bab18f6
Compare
@longfin I amended it, could you review it again? |
PolymorphicAction<T>._actionTypeLoader
cofnigurablePolymorphicAction<T>._actionTypeLoader
configurable
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2873 +/- ##
==========================================
- Coverage 80.30% 80.30% -0.01%
==========================================
Files 313 313
Lines 10751 10752 +1
==========================================
Hits 8634 8634
- Misses 2117 2118 +1
|
This feature is temporary and it should be removed when removing the all
T
generic parameter.