Remove SetValidator action & Make ValidatorStateExtensions to public

[riemannulus]

SSIA

[pull-request-quantifier-deprecated]

This PR has 122 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

---

Quantification details

Label      : Medium
Size       : +4 -118
Percentile : 44.4%

Total files changed: 5

Change summary by file extension:
.md : +3 -0
.cs : +1 -118

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

• Fast and predictable releases to production:
  • Optimal size changes are more likely to be reviewed faster with fewer
    iterations.
  • Similarity in low PR complexity drives similar review times.
• Review quality is likely higher as complexity is lower:
  • Bugs are more likely to be detected.
  • Code inconsistencies are more likely to be detected.
• Knowledge sharing is improved within the participants:
  • Small portions can be assimilated better.
• Better engineering practices are exercised:
  • Solving big problems by dividing them in well contained, smaller problems.
  • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

• Use the PullRequestQuantifier to quantify your PR accurately
  • Create a context profile for your repo using the context generator
  • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
  • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
  • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
• Change your engineering behaviors
  • For PRs that fall outside of the desired spectrum, review the details and check if:
    • Your PR could be split in smaller, self-contained PRs instead
    • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

• One line was added: +1 -0
• One line was deleted: +0 -1
• One line was modified: +1 -1 (git diff doesn't know about modified, it will
  interpret that line like one addition plus one deletion)
• Change percentiles: Change characteristics (addition, deletion, modification)
  of this PR in relation to all other PRs within the repository.

---

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

[codecov]

Codecov Report

Merging #2972 (51df938) into 0.50-maintenance (4de176f) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

@@                 Coverage Diff                  @@
##           0.50-maintenance    #2972      +/-   ##
====================================================
+ Coverage             80.31%   80.35%   +0.04%     
====================================================
  Files                   313      312       -1     
  Lines                 10762    10744      -18     
====================================================
- Hits                   8643     8633      -10     
+ Misses                 2119     2111       -8     

Impacted Files	Coverage Δ
Libplanet/Action/Sys/Registry.cs	100.00% <ø> (ø)
Libplanet/Action/ValidatorStateExtensions.cs	66.66% <ø> (ø)

... and 5 files with indirect coverage changes