Adjust consensus loggings

[limebell]

This changes MessageLog.Add()'s return type to void (which was bool), and throws error instead if failed. Since the method was internal, skip changelog.

[codecov]

Codecov Report

Merging #3046 (a944c60) into 0.53-maintenance (dafff21) will decrease coverage by 0.01%.
The diff coverage is 88.88%.

❗ Current head a944c60 differs from pull request most recent head c7ba08b. Consider uploading reports for the commit c7ba08b to get more accurate results

Additional details and impacted files

@@                 Coverage Diff                  @@
##           0.53-maintenance    #3046      +/-   ##
====================================================
- Coverage             80.98%   80.98%   -0.01%     
====================================================
  Files                   320      320              
  Lines                 11624    11621       -3     
====================================================
- Hits                   9414     9411       -3     
  Misses                 2210     2210              

Impacted Files	Coverage Δ
Libplanet.Net/Consensus/Context.Async.cs	89.61% <71.42%> (ø)
Libplanet.Net/Consensus/MessageLog.cs	93.75% <85.71%> (-0.23%)	⬇️
Libplanet.Net/Consensus/ConsensusContext.cs	95.69% <100.00%> (ø)
Libplanet.Net/Consensus/Context.Mutate.cs	98.05% <100.00%> (-0.02%)	⬇️
Libplanet.Net/Consensus/Context.cs	98.80% <100.00%> (ø)
Libplanet.Net/Consensus/Gossip.cs	90.76% <100.00%> (+0.84%)	⬆️

... and 6 files with indirect coverage changes

[pull-request-quantifier-deprecated]

This PR has 171 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

---

Quantification details

Label      : Medium
Size       : +77 -94
Percentile : 54.2%

Total files changed: 8

Change summary by file extension:
.md : +2 -0
.cs : +75 -94

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

• Fast and predictable releases to production:
  • Optimal size changes are more likely to be reviewed faster with fewer
    iterations.
  • Similarity in low PR complexity drives similar review times.
• Review quality is likely higher as complexity is lower:
  • Bugs are more likely to be detected.
  • Code inconsistencies are more likely to be detected.
• Knowledge sharing is improved within the participants:
  • Small portions can be assimilated better.
• Better engineering practices are exercised:
  • Solving big problems by dividing them in well contained, smaller problems.
  • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

• Use the PullRequestQuantifier to quantify your PR accurately
  • Create a context profile for your repo using the context generator
  • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
  • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
  • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
• Change your engineering behaviors
  • For PRs that fall outside of the desired spectrum, review the details and check if:
    • Your PR could be split in smaller, self-contained PRs instead
    • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

• One line was added: +1 -0
• One line was deleted: +0 -1
• One line was modified: +1 -1 (git diff doesn't know about modified, it will
  interpret that line like one addition plus one deletion)
• Change percentiles: Change characteristics (addition, deletion, modification)
  of this PR in relation to all other PRs within the repository.

---

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.