New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃Ч Remove mining #3067
馃Ч Remove mining #3067
Conversation
b7e5a75
to
0105090
Compare
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 馃憤 聽:ok_hand: 聽:thumbsdown: (Email) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3067 +/- ##
==========================================
- Coverage 80.86% 80.86% -0.01%
==========================================
Files 329 328 -1
Lines 11849 11821 -28
==========================================
- Hits 9582 9559 -23
+ Misses 2267 2262 -5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃殌
Mining code was left in place just in case we wanted to test PoW backward compatibility.
However, realistically speaking, there seems to be no easy way to make a valid PoW chain with current codebase.
Probably an easier approach is to use a prior version to make a PoW chain fixture and import it if we really want to test the backward compatibility feature. 馃檮