Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust how IStore deals with state references and tx nonce #307

Merged
merged 7 commits into from Jun 27, 2019

Conversation

dahlia
Copy link
Contributor

@dahlia dahlia commented Jun 26, 2019

This consists of two changes on the IStore interface and its implementations:

  • Tx nonces is no more stacked but encoded as a single 64-bit integer instead.
  • Multiple state references for an address can be fetched at a time, without multiple method calls.

These changes are needed for implementing #272.

@dahlia dahlia added the suggestion Suggestion or feature request label Jun 26, 2019
@dahlia dahlia added this to the 0.4.0 milestone Jun 26, 2019
@dahlia dahlia requested review from longfin and earlbread June 26, 2019 11:17
@dahlia dahlia self-assigned this Jun 26, 2019
@codecov
Copy link

codecov bot commented Jun 26, 2019

Codecov Report

Merging #307 into master will decrease coverage by 0.2%.
The diff coverage is 90.47%.

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
- Coverage   87.51%   87.31%   -0.21%     
==========================================
  Files         187      189       +2     
  Lines       12690    12604      -86     
==========================================
- Hits        11106    11005     -101     
- Misses       1335     1343       +8     
- Partials      249      256       +7
Impacted Files Coverage Δ
Libplanet/Store/BaseStore.cs 100% <ø> (ø) ⬆️
Libplanet.Tests/Blockchain/BlockChainTest.cs 98.59% <100%> (ø) ⬆️
Libplanet.Tests/Store/StoreTracker.cs 54.31% <100%> (+2.24%) ⬆️
Libplanet.Tests/Store/StoreTest.cs 98.57% <100%> (-0.15%) ⬇️
Libplanet.Tests/Store/StoreExtensionTest.cs 100% <100%> (ø)
Libplanet/Store/LiteDBStore.cs 92.62% <75%> (+0.23%) ⬆️
Libplanet/Blockchain/BlockChain.cs 95.52% <82.35%> (-1.04%) ⬇️
Libplanet/Store/FileStore.cs 90.42% <84%> (-2.99%) ⬇️
Libplanet/Store/StoreExtension.cs 85.71% <85.71%> (ø)
Libplanet.Tests/Store/StoreFixture.cs 92.04% <0%> (-4.55%) ⬇️
... and 3 more

Libplanet.Tests/Store/StoreExtensionTest.cs Outdated Show resolved Hide resolved
Libplanet/Store/StoreExtension.cs Outdated Show resolved Hide resolved
Libplanet/Store/LiteDBStore.cs Outdated Show resolved Hide resolved
.vscode/settings.json Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
Libplanet/Store/FileStore.cs Outdated Show resolved Hide resolved
@dahlia dahlia force-pushed the store-indices branch 2 times, most recently from bedbe8a to d8953dd Compare June 27, 2019 04:34
@dahlia dahlia requested review from longfin and earlbread June 27, 2019 04:35
longfin
longfin previously approved these changes Jun 27, 2019
earlbread
earlbread previously approved these changes Jun 27, 2019
@dahlia
Copy link
Contributor Author

dahlia commented Jun 27, 2019

@earlbread @longfin I fixed a bug that tests didn't work on Unity (I had to replace ValueTuple with Tuple), and wrote a docs about how to run Unity tests. Please review this again.

longfin
longfin previously approved these changes Jun 27, 2019
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-Authored-By: Seunghun Lee <waydi1@gmail.com>
@dahlia dahlia requested review from longfin and earlbread June 27, 2019 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion Suggestion or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants