Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Change Transaction<T> to Transaction #3121

Merged
merged 1 commit into from May 2, 2023
Merged

♻️ Change Transaction<T> to Transaction #3121

merged 1 commit into from May 2, 2023

Conversation

greymistcube
Copy link
Contributor

@greymistcube greymistcube commented Apr 28, 2023 •
edited

Removing <T> from Block<T> will follow shortly. 😗

@greymistcube greymistcube self-assigned this Apr 28, 2023
@greymistcube greymistcube changed the title Remove/transaction t ♻️ Change Transaction<T> to Transaction May 2, 2023
@greymistcube greymistcube marked this pull request as ready for review May 2, 2023 00:50
riemannulus
riemannulus approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@riemannulus riemannulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@greymistcube greymistcube merged commit 2e128e3 into planetarium:main May 2, 2023
16 of 17 checks passed
This was referenced May 2, 2023
Merged
Merged
@greymistcube greymistcube deleted the remove/transaction-t branch May 2, 2023 05:13
@longfin longfin mentioned this pull request May 2, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riemannulus riemannulus riemannulus approved these changes

@limebell limebell Awaiting requested review from limebell

Assignees

@greymistcube greymistcube

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@greymistcube @riemannulus