New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Periodic MessageId
handling in Gossip
#3152
Conversation
6555351
to
3324b76
Compare
a6487eb
to
928b456
Compare
928b456
to
017285b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we add these changes on Behavioral changes
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3152 +/- ##
==========================================
+ Coverage 81.13% 81.22% +0.08%
==========================================
Files 329 329
Lines 11345 11371 +26
==========================================
+ Hits 9205 9236 +31
+ Misses 2140 2135 -5
|
This PR delays reply of
HaveMessage
, to remove total amount of message in the network.You may concern that this patch may delay the network, but gossip broadcasts messages via
Publish()
method at first, and than gossips throughHaveMessage
if any peer fails to receive published message. If a peer failed to receive published message, it means the message is already delayed, so this PR does not significantly affect delay.