-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ ♻️ Added Txs
property to IActionContext
#3713
✨ ♻️ Added Txs
property to IActionContext
#3713
Conversation
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add a condition for adding a value to Txs
to Behavioral changes
.
@riemannulus |
Fair enough. |
In preparation to remove
TotalUpdatedFungibleAssets
fromIWorld
.Having volatile non-state dependency in two different places, namely
IActionContext
andIWorld
, is causing too much trouble. 🙄Also since
ActionEvaluator
is doing more and more heavy lifting in terms of context management, I've widened the scope from which its evaluating methods can pull necessary context from (it was also to avoid adding an additional parameter to numerous methods). This might come in handy later when we introduce evidences. 😗