Remove forked chain when FillBlocksAsync fail #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #537 +/- ##
==========================================
+ Coverage 90.48% 90.67% +0.19%
==========================================
Files 201 201
Lines 15056 15096 +40
==========================================
+ Hits 13624 13689 +65
+ Misses 1147 1122 -25
Partials 285 285
|
earlbread
force-pushed
the
remove-chain-id
branch
from
bd838a2
to
b7fc728
Compare
longfin
reviewed
Sep 26, 2019
longfin
requested changes
Sep 26, 2019
earlbread
force-pushed
the
remove-chain-id
branch
from
aa81a5f
to
801dafe
Compare
longfin
previously approved these changes
Sep 26, 2019
|
It seems to need to rebase. (again 😢 ) |
limebell
previously approved these changes
Sep 26, 2019
|
/rebase |
|
The rebase failed: To rebase manually, run these commands in your terminal: # Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/rebase remove-chain-id
# Navigate to the new directory.
cd .worktrees/rebase
# Rebase and resolve the likely conflicts.
git rebase --interactive --autosquash master
# Push the new branch state to GitHub.
git push --force
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/rebase |
github-actions
bot
dismissed stale reviews from limebell and longfin
via
0b2d7f8
github-actions
bot
force-pushed
the
remove-chain-id
branch
from
801dafe
to
0b2d7f8
Compare
earlbread
force-pushed
the
remove-chain-id
branch
from
0b2d7f8
to
c70f07b
Compare
|
/rebase |
1 similar comment
|
/rebase |
Co-Authored-By: Swen Mun <longfinfunnel@gmail.com>
libplanet
force-pushed
the
remove-chain-id
branch
from
c70f07b
to
c97e9c0
Compare
longfin
approved these changes
Sep 26, 2019
dahlia
approved these changes
Sep 26, 2019
moreal
reviewed
Sep 26, 2019
| @@ -121,6 +121,8 @@ To be released. | |||
| - Fixed a bug that `IActionContext.Random` had been possible to generated | |||
| equivalent results between actions of different transactions in | |||
| a `Block<T>`. [[#519]] | |||
| - Fixed a bug where a forked chain would not be deleted when an exception | |||
| occurred during fetching block from other peers. [[#527], [#535]] | |||
There was a problem hiding this comment.
Is there no pull request reference? and why is there #535 reference?
There was a problem hiding this comment.
My mistake. 😢 I'll fix it in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes forked chain when
FillBlocksAsyncfail.