Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove forked chain when AppendBlocksAsync fail #540

Merged
merged 3 commits into from Sep 26, 2019

Conversation

@earlbread
Copy link
Member

commented Sep 26, 2019

This removes forked chain when FillBlocksAsync fail.

@earlbread earlbread added the bug label Sep 26, 2019
@earlbread earlbread requested review from dahlia, longfin, limebell and moreal Sep 26, 2019
@earlbread earlbread self-assigned this Sep 26, 2019
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
@earlbread earlbread force-pushed the earlbread:fix-remove-chain-id branch from efbd730 to ac17650 Sep 26, 2019
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
Co-Authored-By: Lee Dogeon <dogeonlove0326@gmail.com>
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
Co-Authored-By: Swen Mun <longfinfunnel@gmail.com>
@codecov

This comment has been minimized.

Copy link

commented Sep 26, 2019

Codecov Report

Merging #540 into master will decrease coverage by 0.02%.
The diff coverage is 89.65%.

@@            Coverage Diff             @@
##           master     #540      +/-   ##
==========================================
- Coverage   90.64%   90.61%   -0.03%     
==========================================
  Files         201      201              
  Lines       15107    15117      +10     
==========================================
+ Hits        13693    13699       +6     
- Misses       1128     1131       +3     
- Partials      286      287       +1
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 83.41% <89.65%> (-0.23%) ⬇️
Libplanet/Crypto/PrivateKey.cs 86.2% <0%> (+0.86%) ⬆️
@earlbread earlbread requested review from longfin and moreal Sep 26, 2019
@dahlia
dahlia approved these changes Sep 26, 2019
@longfin longfin merged commit 66313e7 into planetarium:master Sep 26, 2019
17 of 18 checks passed
17 of 18 checks passed
dist
Details
docs
Details
codecov/patch 89.65% of diff hit (target 90.64%)
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/project 90.61% (-0.03%) compared to 865cdfb
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190926.33 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_Benchmark) Windows_NETCore_Benchmark succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
@earlbread earlbread deleted the earlbread:fix-remove-chain-id branch Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.