Remove forked chain when AppendBlocksAsync fail #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
reviewed
Sep 26, 2019
earlbread
force-pushed
the
fix-remove-chain-id
branch
from
efbd730
to
ac17650
Compare
moreal
reviewed
Sep 26, 2019
Co-Authored-By: Lee Dogeon <dogeonlove0326@gmail.com>
longfin
reviewed
Sep 26, 2019
Co-Authored-By: Swen Mun <longfinfunnel@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #540 +/- ##
==========================================
- Coverage 90.64% 90.61% -0.03%
==========================================
Files 201 201
Lines 15107 15117 +10
==========================================
+ Hits 13693 13699 +6
- Misses 1128 1131 +3
- Partials 286 287 +1
|
longfin
approved these changes
Sep 26, 2019
dahlia
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes forked chain when
FillBlocksAsyncfail.