Fix GetNextTxNonce when transactions with old nonce are staged #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #637 +/- ##
==========================================
+ Coverage 88.22% 88.25% +0.02%
==========================================
Files 217 217
Lines 17134 17174 +40
==========================================
+ Hits 15117 15157 +40
Misses 1141 1141
Partials 876 876
|
longfin
reviewed
Oct 30, 2019
earlbread
force-pushed
the
fix-get-next-tx-nonce
branch
from
76f73ea
to
6184d27
Compare
longfin
previously approved these changes
Oct 30, 2019
earlbread
force-pushed
the
fix-get-next-tx-nonce
branch
from
6184d27
to
8451168
Compare
longfin
previously approved these changes
Oct 31, 2019
limebell
previously approved these changes
Oct 31, 2019
earlbread
force-pushed
the
fix-get-next-tx-nonce
branch
from
8451168
to
76106b0
Compare
longfin
previously approved these changes
Nov 1, 2019
moreal
previously approved these changes
Nov 1, 2019
earlbread
force-pushed
the
fix-get-next-tx-nonce
branch
from
76106b0
to
732992e
Compare
longfin
approved these changes
Nov 1, 2019
moreal
approved these changes
Nov 1, 2019
limebell
approved these changes
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where
BlockChain<T>.GetNextTxNonceonly returned the same nonce when transactions with an old nonce were staged.