Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor block related features in BlockChain<T> and IStore #678

Merged

Conversation

@longfin
Copy link
Member

longfin commented Nov 15, 2019

This PR makes some changes in block related features in BlockChain<T> and IStore to distinguish BlockChain<T>.ContainsBlock and IStore.ContainsBlock().

@longfin longfin force-pushed the longfin:feature/seperate-contains-from-chain-2 branch from c952a99 to 2cbab75 Nov 15, 2019
@longfin longfin marked this pull request as ready for review Nov 15, 2019
@longfin longfin requested review from dahlia, moreal, earlbread and limebell Nov 15, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 15, 2019

Codecov Report

Merging #678 into master will decrease coverage by 0.02%.
The diff coverage is 89.79%.

@@            Coverage Diff             @@
##           master     #678      +/-   ##
==========================================
- Coverage    87.3%   87.28%   -0.03%     
==========================================
  Files         218      218              
  Lines       17789    17816      +27     
==========================================
+ Hits        15531    15550      +19     
- Misses       1196     1204       +8     
  Partials     1062     1062
Impacted Files Coverage Δ
Libplanet/Store/BaseStore.cs 81.25% <ø> (ø) ⬆️
Libplanet.Tests/Blockchain/BlockChainTest.cs 98.63% <100%> (ø) ⬆️
Libplanet.Tests/Store/StoreTracker.cs 56.75% <100%> (+1.2%) ⬆️
Libplanet/Net/Swarm.cs 86.01% <100%> (-0.01%) ⬇️
Libplanet/Store/DefaultStore.cs 83.09% <100%> (+0.24%) ⬆️
Libplanet.Tests/Store/StoreTest.cs 97.01% <100%> (+0.05%) ⬆️
Libplanet/Store/BlockSet.cs 88.88% <50%> (ø) ⬆️
Libplanet/Blockchain/BlockChain.cs 93.8% <63.63%> (-1.15%) ⬇️
@longfin longfin self-assigned this Nov 15, 2019
Co-Authored-By: Lee Dogeon <dogeonlove0326@gmail.com>
@longfin longfin requested a review from moreal Nov 15, 2019
@moreal
moreal approved these changes Nov 18, 2019
@dahlia
dahlia approved these changes Nov 18, 2019
@longfin longfin merged commit 67d8b17 into planetarium:master Nov 18, 2019
20 checks passed
20 checks passed
benchmarks (macos-latest)
Details
dist
Details
benchmarks (ubuntu-18.04)
Details
benchmarks (windows-latest)
Details
docs
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 89.79% of diff hit (target 87.3%)
Details
codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +2.48% compared to 0d84f4c
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20191115.3 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.