Refactor block related features in BlockChain<T> and IStore #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
force-pushed
the
feature/seperate-contains-from-chain-2
branch
from
c952a99
to
2cbab75
Compare
Codecov Report
@@ Coverage Diff @@
## master #678 +/- ##
==========================================
- Coverage 87.3% 87.28% -0.03%
==========================================
Files 218 218
Lines 17789 17816 +27
==========================================
+ Hits 15531 15550 +19
- Misses 1196 1204 +8
Partials 1062 1062
|
moreal
previously approved these changes
Nov 15, 2019
Co-Authored-By: Lee Dogeon <dogeonlove0326@gmail.com>
earlbread
approved these changes
Nov 18, 2019
moreal
approved these changes
Nov 18, 2019
dahlia
approved these changes
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some changes in block related features in
BlockChain<T>andIStoreto distinguishBlockChain<T>.ContainsBlockandIStore.ContainsBlock().