-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement RocksDBStore #789
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
reviewed
Feb 7, 2020
longfin
requested changes
Feb 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests seem to fail.
limebell
requested changes
Feb 11, 2020
6677e32
to
9f49cee
Compare
longfin
previously approved these changes
Feb 11, 2020
limebell
previously approved these changes
Feb 12, 2020
moreal
requested changes
Feb 12, 2020
moreal
previously approved these changes
Feb 12, 2020
limebell
previously approved these changes
Feb 12, 2020
longfin
approved these changes
Feb 12, 2020
moreal
approved these changes
Feb 12, 2020
limebell
approved these changes
Feb 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #789 +/- ##
==========================================
+ Coverage 86.65% 86.69% +0.04%
==========================================
Files 227 227
Lines 19654 19654
==========================================
+ Hits 17031 17039 +8
+ Misses 1414 1405 -9
- Partials 1209 1210 +1
|
dahlia
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements RocksDBStore and closes #211. Currently, only the parts stored in the file have been changed to use RocksDB(Please see
IterateTransactionIds
,GetTransaction
,PutTransaction
,DeleteTransaction
,ContainsTransaction
,IterateBlockHashes
,GetBlockDigest
,PutBlock
,DeleteBlock
,ContainsBlock
,GetBlockStates
, andSetBlockStates
methods). Other methods are just the same asDefaultStore
. And alsoRocksDBStoreTest
is skipped in environments where RocksDB is not available for test compatibility.