Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fungible asset states #900

Merged
merged 6 commits into from
Jun 11, 2020
Merged

Fungible asset states #900

merged 6 commits into from
Jun 11, 2020

Conversation

dahlia
Copy link
Contributor

@dahlia dahlia commented Jun 7, 2020

This implements fungible asset states APIs, the first half of the proposal #861. As non-fungible asset states APIs will be orthogonal to this, I am going to send a separated pull request for that later.

The usage can be found in the proposal issue #861 (please read comments I left as well).

@dahlia dahlia self-assigned this Jun 7, 2020
@codecov
Copy link

codecov bot commented Jun 7, 2020

Codecov Report

Merging #900 into master will decrease coverage by 0.13%.
The diff coverage is 90.54%.

@@            Coverage Diff             @@
##           master     #900      +/-   ##
==========================================
- Coverage   87.41%   87.28%   -0.14%     
==========================================
  Files         252      253       +1     
  Lines       23234    23049     -185     
==========================================
- Hits        20311    20118     -193     
- Misses       1546     1552       +6     
- Partials     1377     1379       +2     
Impacted Files Coverage Δ
Libplanet.Tests/Action/ActionContextTest.cs 88.37% <0.00%> (-2.11%) ⬇️
Libplanet/Action/ActionEvaluation.cs 100.00% <ø> (ø)
Libplanet.Tests/Action/ActionEvaluationTest.cs 90.62% <25.00%> (-6.05%) ⬇️
Libplanet/Action/InsufficientBalanceException.cs 66.66% <66.66%> (ø)
Libplanet/Action/CurrencyPermissionException.cs 71.42% <71.42%> (ø)
Libplanet.Tests/Common/Action/DumbAction.cs 80.00% <73.46%> (-1.98%) ⬇️
Libplanet.Tests/Blockchain/BlockChainTest.cs 98.38% <80.00%> (-0.07%) ⬇️
Libplanet/Blockchain/BlockChain.cs 89.09% <81.37%> (-1.72%) ⬇️
...ibplanet.Tests/Action/AccountStateDeltaImplTest.cs 94.68% <93.54%> (-5.32%) ⬇️
Libplanet.Tests/Blocks/BlockTest.cs 98.58% <95.71%> (+0.27%) ⬆️
... and 21 more

@dahlia dahlia marked this pull request as ready for review June 9, 2020 15:09
@dahlia dahlia changed the title WIP: Fungible asset states Fungible asset states Jun 9, 2020
Copy link
Member

@longfin longfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll continue to review again in 3 or 4 hours.

Libplanet/Action/AccountBalanceGetter.cs Show resolved Hide resolved
Libplanet/Action/ActionEvaluation.cs Show resolved Hide resolved
Libplanet/Blockchain/BlockChain.cs Outdated Show resolved Hide resolved
Libplanet/Blocks/Block.cs Show resolved Hide resolved
Libplanet/Currency.cs Outdated Show resolved Hide resolved
Libplanet/Action/AccountStateDeltaImpl.cs Outdated Show resolved Hide resolved
Libplanet/Action/AccountStateDeltaImpl.cs Outdated Show resolved Hide resolved
Libplanet/Currency.cs Outdated Show resolved Hide resolved
Libplanet/Currency.cs Outdated Show resolved Hide resolved
riemannulus
riemannulus previously approved these changes Jun 10, 2020
longfin
longfin previously approved these changes Jun 10, 2020
@dahlia dahlia merged commit 092f2a1 into planetarium:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants