-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fungible asset states #900
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #900 +/- ##
==========================================
- Coverage 87.41% 87.28% -0.14%
==========================================
Files 252 253 +1
Lines 23234 23049 -185
==========================================
- Hits 20311 20118 -193
- Misses 1546 1552 +6
- Partials 1377 1379 +2
|
longfin
reviewed
Jun 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll continue to review again in 3 or 4 hours.
moreal
reviewed
Jun 10, 2020
earlbread
reviewed
Jun 10, 2020
longfin
reviewed
Jun 10, 2020
riemannulus
previously approved these changes
Jun 10, 2020
7ed0b5b
to
d156076
Compare
longfin
previously approved these changes
Jun 10, 2020
longfin
approved these changes
Jun 11, 2020
riemannulus
approved these changes
Jun 11, 2020
earlbread
approved these changes
Jun 11, 2020
moreal
approved these changes
Jun 11, 2020
This was referenced Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements fungible asset states APIs, the first half of the proposal #861. As non-fungible asset states APIs will be orthogonal to this, I am going to send a separated pull request for that later.
The usage can be found in the proposal issue #861 (please read comments I left as well).