Add total difficulty property to Block<T> #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limebell
requested review from
dahlia,
longfin,
earlbread,
riemannulus and
moreal
|
|
limebell
force-pushed
the
feature/total-difficulty
branch
from
8f23690
to
455666d
Compare
dahlia
reviewed
Jul 8, 2020
moreal
reviewed
Jul 8, 2020
limebell
force-pushed
the
feature/total-difficulty
branch
from
455666d
to
46c2d1f
Compare
Codecov Report
@@ Coverage Diff @@
## master #917 +/- ##
==========================================
- Coverage 87.82% 86.76% -1.07%
==========================================
Files 258 235 -23
Lines 23968 23419 -549
==========================================
- Hits 21051 20319 -732
- Misses 1516 1695 +179
- Partials 1401 1405 +4
|
earlbread
reviewed
Jul 8, 2020
longfin
previously approved these changes
Jul 9, 2020
limebell
force-pushed
the
feature/total-difficulty
branch
from
6e495e8
to
010694f
Compare
dahlia
reviewed
Jul 9, 2020
earlbread
previously approved these changes
Jul 9, 2020
dahlia
previously approved these changes
Jul 9, 2020
moreal
previously approved these changes
Jul 9, 2020
…yException.cs Co-authored-by: Hong Minhee (洪 民憙) <hong.minhee@gmail.com>
limebell
force-pushed
the
feature/total-difficulty
branch
from
a9fb16c
to
3408b57
Compare
dahlia
previously approved these changes
Jul 9, 2020
earlbread
previously approved these changes
Jul 9, 2020
longfin
previously approved these changes
Jul 9, 2020
riemannulus
previously approved these changes
Jul 10, 2020
limebell
dismissed stale reviews from riemannulus, longfin, earlbread, and dahlia
via
e9c4ca7
limebell
requested review from
dahlia,
longfin,
earlbread,
riemannulus and
moreal
earlbread
approved these changes
Jul 10, 2020
moreal
approved these changes
Jul 10, 2020
dahlia
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block now has total difficulty property, thus:
Block<T>.Mine()takes total difficulty of previous block.BlockPolicy<T>now checks validity of total difficulty: (total difficulty = difficulty + previous total difficulty)This closes #666.