Separate timeouts in Swarm<T> to SwarmOptions #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earlbread
requested review from
dahlia,
longfin,
limebell,
riemannulus and
moreal
longfin
previously approved these changes
Jul 14, 2020
|
|
||
| namespace Libplanet.Net | ||
| { | ||
| public class SwarmOptions |
There was a problem hiding this comment.
How about using struct instead of class?
There was a problem hiding this comment.
I made it to a class to use initializers. Would it be better to change it to struct?
There was a problem hiding this comment.
Maybe... because it seems just data class. but on the other way, it isn't a big deal.
dahlia
reviewed
Jul 14, 2020
dahlia
approved these changes
Jul 14, 2020
Codecov Report
@@ Coverage Diff @@
## master #926 +/- ##
==========================================
- Coverage 87.83% 87.82% -0.01%
==========================================
Files 260 261 +1
Lines 24192 24196 +4
==========================================
+ Hits 21248 21250 +2
- Misses 1530 1531 +1
- Partials 1414 1415 +1
|
longfin
approved these changes
Jul 14, 2020
riemannulus
approved these changes
Jul 15, 2020
moreal
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate timeouts in
Swarm<T>toSwarmOptionsto be configurable.