-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate timeouts in Swarm<T> to SwarmOptions #926
Conversation
|
||
namespace Libplanet.Net | ||
{ | ||
public class SwarmOptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about using struct
instead of class
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made it to a class
to use initializers. Would it be better to change it to struct
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe... because it seems just data class. but on the other way, it isn't a big deal.
Codecov Report
@@ Coverage Diff @@
## master #926 +/- ##
==========================================
- Coverage 87.83% 87.82% -0.01%
==========================================
Files 260 261 +1
Lines 24192 24196 +4
==========================================
+ Hits 21248 21250 +2
- Misses 1530 1531 +1
- Partials 1414 1415 +1
|
Separate timeouts in
Swarm<T>
toSwarmOptions
to be configurable.