Don't throw exception when connecting to all neighbors fails #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earlbread
requested review from
dahlia,
longfin,
limebell,
riemannulus and
moreal
longfin
previously approved these changes
Jul 23, 2020
limebell
previously approved these changes
Jul 23, 2020
moreal
previously approved these changes
Jul 23, 2020
Codecov Report
@@ Coverage Diff @@
## master #933 +/- ##
==========================================
+ Coverage 87.96% 88.03% +0.07%
==========================================
Files 263 263
Lines 24223 24200 -23
==========================================
- Hits 21307 21304 -3
+ Misses 1512 1489 -23
- Partials 1404 1407 +3
|
dahlia
reviewed
Jul 23, 2020
| !(task.Exception is null) && | ||
| task.Exception.InnerExceptions.All(ex => ex is TimeoutException))) | ||
| { | ||
| throw new TimeoutException( |
There was a problem hiding this comment.
Do we log inner exceptions in other places? If not it might better to log them here. 🤔
There was a problem hiding this comment.
I thought the inner exceptions are logged here. https://github.com/planetarium/libplanet/pull/933/files#diff-ae527d5afcdf41da4a57b594cab3cfefL655
Co-authored-by: Hong Minhee (洪 民憙) <hong.minhee@gmail.com>
earlbread
force-pushed
the
neighbor-connect-fail
branch
from
c9ae648
to
2495685
Compare
|
I removed another exception https://github.com/planetarium/libplanet/pull/933/files#diff-ae527d5afcdf41da4a57b594cab3cfefL698 |
dahlia
approved these changes
Jul 23, 2020
longfin
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes to not throw an exception in
Swarm.BootstrapAsync()when connecting to all neighbors fails.