Find specific peer from network #981
Conversation
Codecov Report
@@ Coverage Diff @@
## main #981 +/- ##
==========================================
+ Coverage 88.79% 88.89% +0.10%
==========================================
Files 319 320 +1
Lines 28130 28132 +2
==========================================
+ Hits 24977 25007 +30
+ Misses 1602 1597 -5
+ Partials 1551 1528 -23
|
| @@ -708,53 +714,35 @@ private void ReceivePing(Ping ping) | |||
| { | |||
| await Task.WhenAll(awaitables); | |||
| } | |||
| catch (AggregateException e) | |||
| catch (Exception e) | |||
There was a problem hiding this comment.
@limebell What kind of exceptions do you expect to be thrown here?
There was a problem hiding this comment.
Usually TimeoutException, which occurs when the received peer is not alive actually.
There was a problem hiding this comment.
I made TimeoutException (which is replaced by PingTimeoutException) to remove peer from lookup candidate, which will be covered by SwarmTest.FindSpecificPeerAsyncFail() test.
| { | ||
| peerFound = closestNeighbors[i]; | ||
| return peerFound; | ||
| continue; |
There was a problem hiding this comment.
Would it be difficult to have a unit test for this case?
limebell
force-pushed
the
feature/peer-finder
branch
from
4070cfa
to
5002ceb
Compare
limebell
force-pushed
the
feature/peer-finder
branch
from
5002ceb
to
bd759ac
Compare
|
Method implemented in this PR keeps searching even the specific target is found. I will add some commits on this PR to fix the issue. Until then, leave title as WIP. |
limebell
changed the title
limebell
force-pushed
the
feature/peer-finder
branch
from
3e5a10c
to
b82d753
Compare
limebell
changed the title
|
Used DFS beforehand, may cause stack overflow. So I changed it to BFS by using concurrent queue and stop immediately when target peer is found. However |
limebell
force-pushed
the
feature/peer-finder
branch
from
f015aec
to
7096e7a
Compare
limebell
force-pushed
the
feature/peer-finder
branch
from
17d3614
to
4b0e7d4
Compare
Co-authored-by: Hong Minhee (洪 民憙) <hong.minhee@gmail.com>
PingAsync now throws PingTimeoutException instead of TimeoutException [skip changelog]
Co-authored-by: Seunghun Lee <waydi1@gmail.com>
Co-authored-by: Hong Minhee (洪 民憙) <hong.minhee@gmail.com>
Co-authored-by: Swen Mun <longfinfunnel@gmail.com>
Co-authored-by: Swen Mun <longfinfunnel@gmail.com>
limebell
force-pushed
the
feature/peer-finder
branch
from
4b0e7d4
to
44c6e12
Compare
There was
Swarm<T>.FindSpecificPeerAsync()method but it was not precise. This PR makes it to work more precisely.