Kpic #60
Merged
Kpic #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiber_contrast_gain = 2 instead 10 because 10 assumes speckle nulling Calculating chromatic ao throughput based on hispec file fixed units for separation in get_speckle_noise
-Introduced new material and throughput files for surfaces in MODHIS -Introduced new functions to calculate component throughputs which are in turn called by get_inst_throughput -Added calculations of thermal background from instrument components (hopefully correctly) -Made a copy of the PSISIM HISPEC Tutorial Notebook, but replacing Keck/HISPEC with TMT/MODHIS
Also adding new throughput and background budget from Dimitri for hispec, kpic1, kpic2
semaphoreP
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merging