Security: Increase start up password field height and display keyboard on load #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itswisdomagain
approved these changes
Jun 10, 2019
quacklabs
pushed a commit
to quacklabs/dcrios
that referenced
this pull request
Aug 14, 2019
…d on load (planetdecred#467) * Increase password field height and display keyboard on load * resize textfield height and font
quacklabs
pushed a commit
to quacklabs/dcrios
that referenced
this pull request
Aug 20, 2019
…d on load (planetdecred#467) * Increase password field height and display keyboard on load * resize textfield height and font
itswisdomagain
pushed a commit
to itswisdomagain/dcrios
that referenced
this pull request
Aug 21, 2019
* Fixed issue 358 - Fixed bug where app crashed once input went beyond 5 characters by setting maximum characters to 5 - Resolved PIn strength meter issue by toggling its visibility on PIN commit button action. * made changes suggested Changes suggested on review of Pull request #2 - Updated Cocoapods - fixed typos - removed unneccesary spaces * Fixed issue 372 - changed maximum Int to LONG_MAX - Moved layer clear block to draw function - remove unneccessary type casting on pin lable to improve performance - changed remove from superview block to use an array map style instead * refactored commit #e4174d51aed804a470b8d42f08229756f8993915 * refactored commit d097f90 - Removed unwanted comments - Added comments to lines needing clarification. - refactored drawPinLabel to accept an argument containing label bounds * Fixed app crash on 6> digit PIN delete - moved subview removal to before didSetDisplay() block * Fixed issue 384 - Added border around active tab on selection - Remove border around inactive tab on selection of other tab * Fixed issue 358 - Fixed bug where app crashed once input went beyond 5 characters by setting maximum characters to 5 - Resolved PIn strength meter issue by toggling its visibility on PIN commit button action. * made changes suggested Changes suggested on review of Pull request #2 - Updated Cocoapods - fixed typos - removed unneccesary spaces * Fixed issue 372 - changed maximum Int to LONG_MAX - Moved layer clear block to draw function - remove unneccessary type casting on pin lable to improve performance - changed remove from superview block to use an array map style instead * refactored commit #e4174d51aed804a470b8d42f08229756f8993915 * refactored commit d097f90 - Removed unwanted comments - Added comments to lines needing clarification. - refactored drawPinLabel to accept an argument containing label bounds * Fixed app crash on 6> digit PIN delete - moved subview removal to before didSetDisplay() block * Fixed issue 384 - Added border around active tab on selection - Remove border around inactive tab on selection of other tab * Fixed issue 358 - Fixed bug where app crashed once input went beyond 5 characters by setting maximum characters to 5 - Resolved PIn strength meter issue by toggling its visibility on PIN commit button action. * made changes suggested Changes suggested on review of Pull request #2 - Updated Cocoapods - fixed typos - removed unneccesary spaces * Fixed issue 372 - changed maximum Int to LONG_MAX - Moved layer clear block to draw function - remove unneccessary type casting on pin lable to improve performance - changed remove from superview block to use an array map style instead * refactored commit #e4174d51aed804a470b8d42f08229756f8993915 * refactored commit d097f90 - Removed unwanted comments - Added comments to lines needing clarification. - refactored drawPinLabel to accept an argument containing label bounds * Fixed app crash on 6> digit PIN delete - moved subview removal to before didSetDisplay() block * Fixed issue 384 - Added border around active tab on selection - Remove border around inactive tab on selection of other tab * fix crash on wifi option display and set maximum with for navigation drawer (planetdecred#410) * display no transactions text on overview/history pages when appropriate (planetdecred#412) * Pin pass tab fix (planetdecred#414) * Fixed issue 384 - Added border color key/value attribute to password & pin tabs on storyboard - added code to change border width on tab activation * deleted decred_wallet.xcworkspace - deleted decred_wallet.xcworkspace * Updated PIN/Password tab - set PIN & Password tab buttons to custom Button class and checked it can be used in storyboard OK - set the button border color * Fixed issue 384 - Added border color key/value attribute to password & pin tabs on storyboard - added code to change border width on tab activation * deleted decred_wallet.xcworkspace - deleted decred_wallet.xcworkspace * Updated PIN/Password tab - set PIN & Password tab buttons to custom Button class and checked it can be used in storyboard OK - set the button border color * Fixed PIN/Password Tab accessibility - added border to bottom and right or left - created function extending projects Button class to add or remove borders accordingly * refactor * cleanup * Settings page cleanup (planetdecred#418) * remove unused testnet switch, remove save/cancel buttons * cleanup * change Incoming Transaction Notification setting option layout * set compression resistance priority to make label shrink first * delete irrelevant entries from gitignore * correct status for new tx in overview/history, correct pin/pass tab borders (planetdecred#425) * Set password field as first responder (planetdecred#428) * Set password field as first responder * add self on button call * fix typo in comment * Remove dark background when PIN confirm button is clicked (planetdecred#427) * send page refactor and bug fixes (planetdecred#413) * new send page in progress * done with page validations * send refactor complete * cleanup * send confirm - return toproceed * send confirm - return to proceed * more cleanup * move files around * fix send max * ok and view buttons on send success * use single instance of send page to retain view state * don't hide exchange rate label when re-fetching * don't hide usd amount field when re-fetching * correct send amount verification, make amount reduce font size if necessary * resolve send max issues * unset exchange rate value if setting is changed to no exchange rate * punctuate error message * punctuate error message * capitalize exchange rate text in error display, add punctuation * updates to support latest sync changes on dcrlibwallet/master (planetdecred#433) * updates to support latest sync changes on dcrlibwallet/master * ignore sync listener add error * fix network lost/app sleep coincidence * Settings view cleanup (planetdecred#429) * change spend unconfirm fund Text * disable user interaction on wallet log * add copy button to copy wallet log * enable user interaction and disable editing * Remove Show debug messages on settings * refactor settings * hide delete button from settings, undo changes to main.storyboard * undo changes to main.storyboard * correct file paths * fixing file arrangements * move all settings-related files to Features/Settings * remove settings and related vcs from main.storyboard * cleanup settings * show nav back button when settings is opened from splash screen * cleanup wallet log copy function * clean up security menu UI (planetdecred#426) * clean up security menu UI * refactor security menu * configure security menu storyboard * fix project.pbxproj errors with file listings * Remove security menu VC from main storyboard * fix file listing error * Navigation drawer fix (planetdecred#438) * adjust spacing on drawer * clean up nav bar * align syn status label to center * Rename security menu icon and removed redundant background color set * Implement delete wallet function (planetdecred#439) * implement delete wallet function * cleanup modal * correct delete wallet modal title * remove splash logo double tap action * move scrolling focus down to 2/3 of the screen (planetdecred#442) * move scrolling focus to 2/3 of the screen * scroll to bottom only if next row is not already visible * fix send max button to exhibit consistent behaviour (planetdecred#435) * fix send max button to exhibit consistent behaviour * further improvements to send max behaviour * refactor send page to use new dcrlibwallet functions * build after rebase * clear tx summary on amount clear, fix . as amount crash * improve amount validation * ignore max amount values and display error * sync related adjustments from dcrlibwallet/master * re-calculate send max amount if source account is changed * Restore double tap splash screen logo to show settings. Prevent settings crash if wallet is not opened. (planetdecred#447) * restore double tap splash screen logo to show settings * tap gesture on logo region instead of logo * hide wallet options when wallet is not open * hide rescan blockchain and delete wallet option in settings (planetdecred#448) * update project files * Delete wallet fix (planetdecred#444) * invalidate sync timer * fix changes requested * add empty line to differ code * update code to work with dcrlibwallet shutdown wallet fix * Implement Settings -> Rescan Blockchain (planetdecred#445) * implement block rescan * do not treat rescan progress as active sync->rescan progress * do not update nav menu labels during rescan * don't rescan if sync is in progress * allow updating balance during rescan * show delete wallet and rescan blocchain settings options if wallet is opened * Settings: add button to show open source license (planetdecred#450) * License show in settings * add disclosure indicator to button, connection link and fix contraint * fix text wrap and spacing * fix text color and delete generated viewDidLoD comment * dark gray color used for license text * Fixed issue 358 - Fixed bug where app crashed once input went beyond 5 characters by setting maximum characters to 5 - Resolved PIn strength meter issue by toggling its visibility on PIN commit button action. * pin setup view - show as many dots as possible (planetdecred#452) * Use different app display names for testnet and mainnet (planetdecred#453) * Fix mainnet logo on navigation drawer (planetdecred#463) * Overview, history pages: blink for new transactions (planetdecred#464) * overview blink on new txs and incoming tx, history blink on new txs * implement incoming tx notification listener for history * Send page improvements: hide account dropdowns when leaving page, properly handle invalid passphrase error (planetdecred#466) * hide dropdown when leaving send page * send page: show retry dialog on incorrect passphrase * Settings: Use constants for preference keys (planetdecred#465) * Use constants for preference keys * fix changes requested on PR * Renamed variable names * further moving userdefault to settings * fix changes and refactor * add accountHeader file * fix indent * Security: Increase start up password field height and display keyboard on load (planetdecred#467) * Increase password field height and display keyboard on load * resize textfield height and font * restart sync if it stalls for 30 seconds (planetdecred#472) * dont show receive address during wallet restore (planetdecred#473) * dont show receive address during wallet restore * alowing the receive menu content when its the first wallet set up * PR changes and code refactor * refactor work and renaming of functions to be more readable * if else statement * removal of un needed check * hiding the bar items when in sync * security page: restyle tab for pass/pin (planetdecred#469) * Restyle tab for pass/pin * remove white space * remove white space * Add highlighted background on button * clean up and refactor * fix changes requested in PR * fix changes requested in PR * ipod icons stretch fix (planetdecred#474) * update dcrlibwallet GetTransaction method usage (planetdecred#480) * App Localization and Translation(Russia) (planetdecred#470) * Restyle tab for pass/pin * remove white space * remove white space * Internationalize app and extract strings from views(storyboard,xib and cells) * Move and centralize view controller string * Cont: move,format and centralize view controller string * fix crash caused by encoding * Finalize: move,format and centralize view controller string * delete multiple strings files from views and storyboard * fix cliping error on components for localozable screen * link all string UI component to single file, fix cliping components and clean up files * changing the strings to match android,implement russian translation and fix displaced view * delete redundant files * fix text string links * Remove changes meant for a diffrent PR * delete unused string * revert tab color code * delete duplicate string * localize string update from recent PR * Remove developer team from build * Place localized string in struct for easy readability and usage * link all strings from struct to app * fix copyright header and delete unused singleInstance.swift file * fix changes requested * PR changes requested: create UILable for localized string * clean up multiple strings * fix changes requested in PR * fix settings link with localizedkey * Rename incorrectSecurityInfo key * Remove developer team * Remove extra period from UILabel name * fix typo in spelling * fix changes requested on dummy Text and spacing * delete unused controller and storyboard and few string changes * Remove unused code in label extension * Remove devloper team * new wallet->verify seed: fix seed word selection scrambling on page scroll (planetdecred#483) * new wallet->verify seed: fix seed word selection scrambling on page scroll * remove test/dev print code * Seed Verify: Auto scroll up to show confirm button (planetdecred#485) * auto scroll up to show confirm button * show confirm button on scroll end, not before * IPodTouch: Fix chopped off text UI on overview and security page (planetdecred#487) * Fix chopped off UI on overview and security page * fix dropdown image into button * Remove developer team * fix cancel image on button in security page * change device id * delete unused label * change overview device * change line break to truncate tail * don't restart sync due to delayed updates (stalling) if sync was already completed (planetdecred#489) * refactor stalled sync restart code (planetdecred#490) * adopt dcrlibwallet RestartSpvSync method to fix app restart sync issues on a synced wallet (planetdecred#491) * fix crash on ipad when sharing address (planetdecred#494) * fix crash on ipad when sharing address * fix popup view to the right of barButton * fix link to view on mainnet explorer (planetdecred#496) * App translation and string rearrangement: zh (planetdecred#482) * translation: zh * Fix string id changes from master and other changes related to strings * Rearrange all string files according to app launch * Fix syntax error * move localized string into Decred Wallet directory * Rename PasswordDoNotMatch ID * Account details : Fix overlapping text (planetdecred#501) * fix overlapping text on account details * fix overlapping text on key row * App Translation:Pt-br (planetdecred#497) * translation: zh * Fix string id changes from master and other changes related to strings * Rearrange all string files according to app launch * Copy strings from dcrandroid to implement portuguese(Brazil) translation * Fix syntax error * move localized string into Decred Wallet directory * Rename PasswordDoNotMatch ID * App Translation:Vi (planetdecred#498) * translation: zh * Fix string id changes from master and other changes related to strings * Rearrange all string files according to app launch * Fix syntax error * Copy strings from dcrandroid to implement Vietnamese translation * move localized string into Decred Wallet directory * Rename PasswordDoNotMatch ID * App Translation: Spanish (planetdecred#500) * translation: zh * Fix string id changes from master and other changes related to strings * Rearrange all string files according to app launch * Fix syntax error * Copy strings from dcrandroid to implement spanish translation * move localized string into Decred Wallet directory * Rename PasswordDoNotMatch ID * made changes suggested Changes suggested on review of Pull request #2 - Updated Cocoapods - fixed typos - removed unneccesary spaces * Fixed issue 372 - changed maximum Int to LONG_MAX - Moved layer clear block to draw function - remove unneccessary type casting on pin lable to improve performance - changed remove from superview block to use an array map style instead * refactored commit #e4174d51aed804a470b8d42f08229756f8993915 * refactored commit d097f90 - Removed unwanted comments - Added comments to lines needing clarification. - refactored drawPinLabel to accept an argument containing label bounds * Fixed app crash on 6> digit PIN delete - moved subview removal to before didSetDisplay() block * Fixed issue 384 - Added border around active tab on selection - Remove border around inactive tab on selection of other tab * Finished start screen * removed unused variables and strings * switched remote branch * switched remote branch * Fixed issue 358 - Fixed bug where app crashed once input went beyond 5 characters by setting maximum characters to 5 - Resolved PIn strength meter issue by toggling its visibility on PIN commit button action. * made changes suggested Changes suggested on review of Pull request #2 - Updated Cocoapods - fixed typos - removed unneccesary spaces * Fixed issue 372 - changed maximum Int to LONG_MAX - Moved layer clear block to draw function - remove unneccessary type casting on pin lable to improve performance - changed remove from superview block to use an array map style instead * refactored commit #e4174d51aed804a470b8d42f08229756f8993915 * refactored commit d097f90 - Removed unwanted comments - Added comments to lines needing clarification. - refactored drawPinLabel to accept an argument containing label bounds * Fixed app crash on 6> digit PIN delete - moved subview removal to before didSetDisplay() block * Fixed issue 384 - Added border around active tab on selection - Remove border around inactive tab on selection of other tab * Fixed issue 358 - Fixed bug where app crashed once input went beyond 5 characters by setting maximum characters to 5 - Resolved PIn strength meter issue by toggling its visibility on PIN commit button action. * made changes suggested Changes suggested on review of Pull request #2 - Updated Cocoapods - fixed typos - removed unneccesary spaces * Fixed issue 372 - changed maximum Int to LONG_MAX - Moved layer clear block to draw function - remove unneccessary type casting on pin lable to improve performance - changed remove from superview block to use an array map style instead * refactored commit #e4174d51aed804a470b8d42f08229756f8993915 * refactored commit d097f90 - Removed unwanted comments - Added comments to lines needing clarification. - refactored drawPinLabel to accept an argument containing label bounds * Fixed app crash on 6> digit PIN delete - moved subview removal to before didSetDisplay() block * Fixed issue 384 - Added border around active tab on selection - Remove border around inactive tab on selection of other tab * Fixed issue 358 - Fixed bug where app crashed once input went beyond 5 characters by setting maximum characters to 5 - Resolved PIn strength meter issue by toggling its visibility on PIN commit button action. * made changes suggested Changes suggested on review of Pull request #2 - Updated Cocoapods - fixed typos - removed unneccesary spaces * Fixed issue 372 - changed maximum Int to LONG_MAX - Moved layer clear block to draw function - remove unneccessary type casting on pin lable to improve performance - changed remove from superview block to use an array map style instead * refactored commit #e4174d51aed804a470b8d42f08229756f8993915 * refactored commit d097f90 - Removed unwanted comments - Added comments to lines needing clarification. - refactored drawPinLabel to accept an argument containing label bounds * Fixed app crash on 6> digit PIN delete - moved subview removal to before didSetDisplay() block * Fixed issue 384 - Added border around active tab on selection - Remove border around inactive tab on selection of other tab * display no transactions text on overview/history pages when appropriate (planetdecred#412) * Pin pass tab fix (planetdecred#414) * Fixed issue 384 - Added border color key/value attribute to password & pin tabs on storyboard - added code to change border width on tab activation * deleted decred_wallet.xcworkspace - deleted decred_wallet.xcworkspace * Updated PIN/Password tab - set PIN & Password tab buttons to custom Button class and checked it can be used in storyboard OK - set the button border color * Fixed issue 384 - Added border color key/value attribute to password & pin tabs on storyboard - added code to change border width on tab activation * deleted decred_wallet.xcworkspace - deleted decred_wallet.xcworkspace * Updated PIN/Password tab - set PIN & Password tab buttons to custom Button class and checked it can be used in storyboard OK - set the button border color * Fixed PIN/Password Tab accessibility - added border to bottom and right or left - created function extending projects Button class to add or remove borders accordingly * refactor * cleanup * Settings page cleanup (planetdecred#418) * remove unused testnet switch, remove save/cancel buttons * cleanup * change Incoming Transaction Notification setting option layout * set compression resistance priority to make label shrink first * delete irrelevant entries from gitignore * correct status for new tx in overview/history, correct pin/pass tab borders (planetdecred#425) * send page refactor and bug fixes (planetdecred#413) * new send page in progress * done with page validations * send refactor complete * cleanup * send confirm - return toproceed * send confirm - return to proceed * more cleanup * move files around * fix send max * ok and view buttons on send success * use single instance of send page to retain view state * don't hide exchange rate label when re-fetching * don't hide usd amount field when re-fetching * correct send amount verification, make amount reduce font size if necessary * resolve send max issues * unset exchange rate value if setting is changed to no exchange rate * punctuate error message * punctuate error message * capitalize exchange rate text in error display, add punctuation * Settings view cleanup (planetdecred#429) * change spend unconfirm fund Text * disable user interaction on wallet log * add copy button to copy wallet log * enable user interaction and disable editing * Remove Show debug messages on settings * refactor settings * hide delete button from settings, undo changes to main.storyboard * undo changes to main.storyboard * correct file paths * fixing file arrangements * move all settings-related files to Features/Settings * remove settings and related vcs from main.storyboard * cleanup settings * show nav back button when settings is opened from splash screen * cleanup wallet log copy function * clean up security menu UI (planetdecred#426) * clean up security menu UI * refactor security menu * configure security menu storyboard * fix project.pbxproj errors with file listings * Remove security menu VC from main storyboard * fix file listing error * Navigation drawer fix (planetdecred#438) * adjust spacing on drawer * clean up nav bar * align syn status label to center * Rename security menu icon and removed redundant background color set * Implement delete wallet function (planetdecred#439) * implement delete wallet function * cleanup modal * correct delete wallet modal title * remove splash logo double tap action * move scrolling focus down to 2/3 of the screen (planetdecred#442) * move scrolling focus to 2/3 of the screen * scroll to bottom only if next row is not already visible * fix send max button to exhibit consistent behaviour (planetdecred#435) * fix send max button to exhibit consistent behaviour * further improvements to send max behaviour * refactor send page to use new dcrlibwallet functions * build after rebase * clear tx summary on amount clear, fix . as amount crash * improve amount validation * ignore max amount values and display error * sync related adjustments from dcrlibwallet/master * re-calculate send max amount if source account is changed * Restore double tap splash screen logo to show settings. Prevent settings crash if wallet is not opened. (planetdecred#447) * restore double tap splash screen logo to show settings * tap gesture on logo region instead of logo * hide wallet options when wallet is not open * hide rescan blockchain and delete wallet option in settings (planetdecred#448) * update project files * Delete wallet fix (planetdecred#444) * invalidate sync timer * fix changes requested * add empty line to differ code * update code to work with dcrlibwallet shutdown wallet fix * Implement Settings -> Rescan Blockchain (planetdecred#445) * implement block rescan * do not treat rescan progress as active sync->rescan progress * do not update nav menu labels during rescan * don't rescan if sync is in progress * allow updating balance during rescan * show delete wallet and rescan blocchain settings options if wallet is opened * Settings: add button to show open source license (planetdecred#450) * License show in settings * add disclosure indicator to button, connection link and fix contraint * fix text wrap and spacing * fix text color and delete generated viewDidLoD comment * dark gray color used for license text * pin setup view - show as many dots as possible (planetdecred#452) * Use different app display names for testnet and mainnet (planetdecred#453) * Fix mainnet logo on navigation drawer (planetdecred#463) * Overview, history pages: blink for new transactions (planetdecred#464) * overview blink on new txs and incoming tx, history blink on new txs * implement incoming tx notification listener for history * Send page improvements: hide account dropdowns when leaving page, properly handle invalid passphrase error (planetdecred#466) * hide dropdown when leaving send page * send page: show retry dialog on incorrect passphrase * Settings: Use constants for preference keys (planetdecred#465) * Use constants for preference keys * fix changes requested on PR * Renamed variable names * further moving userdefault to settings * fix changes and refactor * add accountHeader file * fix indent * Security: Increase start up password field height and display keyboard on load (planetdecred#467) * Increase password field height and display keyboard on load * resize textfield height and font * restart sync if it stalls for 30 seconds (planetdecred#472) * dont show receive address during wallet restore (planetdecred#473) * dont show receive address during wallet restore * alowing the receive menu content when its the first wallet set up * PR changes and code refactor * refactor work and renaming of functions to be more readable * if else statement * removal of un needed check * hiding the bar items when in sync * security page: restyle tab for pass/pin (planetdecred#469) * Restyle tab for pass/pin * remove white space * remove white space * Add highlighted background on button * clean up and refactor * fix changes requested in PR * fix changes requested in PR * ipod icons stretch fix (planetdecred#474) * update dcrlibwallet GetTransaction method usage (planetdecred#480) * App Localization and Translation(Russia) (planetdecred#470) * Restyle tab for pass/pin * remove white space * remove white space * Internationalize app and extract strings from views(storyboard,xib and cells) * Move and centralize view controller string * Cont: move,format and centralize view controller string * fix crash caused by encoding * Finalize: move,format and centralize view controller string * delete multiple strings files from views and storyboard * fix cliping error on components for localozable screen * link all string UI component to single file, fix cliping components and clean up files * changing the strings to match android,implement russian translation and fix displaced view * delete redundant files * fix text string links * Remove changes meant for a diffrent PR * delete unused string * revert tab color code * delete duplicate string * localize string update from recent PR * Remove developer team from build * Place localized string in struct for easy readability and usage * link all strings from struct to app * fix copyright header and delete unused singleInstance.swift file * fix changes requested * PR changes requested: create UILable for localized string * clean up multiple strings * fix changes requested in PR * fix settings link with localizedkey * Rename incorrectSecurityInfo key * Remove developer team * Remove extra period from UILabel name * fix typo in spelling * fix changes requested on dummy Text and spacing * delete unused controller and storyboard and few string changes * Remove unused code in label extension * Remove devloper team * new wallet->verify seed: fix seed word selection scrambling on page scroll (planetdecred#483) * new wallet->verify seed: fix seed word selection scrambling on page scroll * remove test/dev print code * Seed Verify: Auto scroll up to show confirm button (planetdecred#485) * auto scroll up to show confirm button * show confirm button on scroll end, not before * IPodTouch: Fix chopped off text UI on overview and security page (planetdecred#487) * Fix chopped off UI on overview and security page * fix dropdown image into button * Remove developer team * fix cancel image on button in security page * change device id * delete unused label * change overview device * change line break to truncate tail * don't restart sync due to delayed updates (stalling) if sync was already completed (planetdecred#489) * refactor stalled sync restart code (planetdecred#490) * adopt dcrlibwallet RestartSpvSync method to fix app restart sync issues on a synced wallet (planetdecred#491) * App translation and string rearrangement: zh (planetdecred#482) * translation: zh * Fix string id changes from master and other changes related to strings * Rearrange all string files according to app launch * Fix syntax error * move localized string into Decred Wallet directory * Rename PasswordDoNotMatch ID * Account details : Fix overlapping text (planetdecred#501) * fix overlapping text on account details * fix overlapping text on key row * App Translation:Vi (planetdecred#498) * translation: zh * Fix string id changes from master and other changes related to strings * Rearrange all string files according to app launch * Fix syntax error * Copy strings from dcrandroid to implement Vietnamese translation * move localized string into Decred Wallet directory * Rename PasswordDoNotMatch ID * Fixed issue 358 - Fixed bug where app crashed once input went beyond 5 characters by setting maximum characters to 5 - Resolved PIn strength meter issue by toggling its visibility on PIN commit button action. * made changes suggested Changes suggested on review of Pull request #2 - Updated Cocoapods - fixed typos - removed unneccesary spaces * Fixed issue 372 - changed maximum Int to LONG_MAX - Moved layer clear block to draw function - remove unneccessary type casting on pin lable to improve performance - changed remove from superview block to use an array map style instead * refactored commit #e4174d51aed804a470b8d42f08229756f8993915 * refactored commit d097f90 - Removed unwanted comments - Added comments to lines needing clarification. - refactored drawPinLabel to accept an argument containing label bounds * Fixed app crash on 6> digit PIN delete - moved subview removal to before didSetDisplay() block * Fixed issue 384 - Added border around active tab on selection - Remove border around inactive tab on selection of other tab * Finished start screen * removed unused variables and strings * switched remote branch * switched remote branch
itswisdomagain
pushed a commit
to itswisdomagain/dcrios
that referenced
this pull request
Aug 31, 2019
* Fixed issue 358 - Fixed bug where app crashed once input went beyond 5 characters by setting maximum characters to 5 - Resolved PIn strength meter issue by toggling its visibility on PIN commit button action. * made changes suggested Changes suggested on review of Pull request #2 - Updated Cocoapods - fixed typos - removed unneccesary spaces * Fixed issue 372 - changed maximum Int to LONG_MAX - Moved layer clear block to draw function - remove unneccessary type casting on pin lable to improve performance - changed remove from superview block to use an array map style instead * refactored commit #e4174d51aed804a470b8d42f08229756f8993915 * refactored commit d097f90 - Removed unwanted comments - Added comments to lines needing clarification. - refactored drawPinLabel to accept an argument containing label bounds * Fixed app crash on 6> digit PIN delete - moved subview removal to before didSetDisplay() block * Fixed issue 384 - Added border around active tab on selection - Remove border around inactive tab on selection of other tab * Fixed issue 358 - Fixed bug where app crashed once input went beyond 5 characters by setting maximum characters to 5 - Resolved PIn strength meter issue by toggling its visibility on PIN commit button action. * made changes suggested Changes suggested on review of Pull request #2 - Updated Cocoapods - fixed typos - removed unneccesary spaces * Fixed issue 372 - changed maximum Int to LONG_MAX - Moved layer clear block to draw function - remove unneccessary type casting on pin lable to improve performance - changed remove from superview block to use an array map style instead * refactored commit #e4174d51aed804a470b8d42f08229756f8993915 * refactored commit d097f90 - Removed unwanted comments - Added comments to lines needing clarification. - refactored drawPinLabel to accept an argument containing label bounds * Fixed app crash on 6> digit PIN delete - moved subview removal to before didSetDisplay() block * Fixed issue 384 - Added border around active tab on selection - Remove border around inactive tab on selection of other tab * Fixed issue 358 - Fixed bug where app crashed once input went beyond 5 characters by setting maximum characters to 5 - Resolved PIn strength meter issue by toggling its visibility on PIN commit button action. * made changes suggested Changes suggested on review of Pull request #2 - Updated Cocoapods - fixed typos - removed unneccesary spaces * Fixed issue 372 - changed maximum Int to LONG_MAX - Moved layer clear block to draw function - remove unneccessary type casting on pin lable to improve performance - changed remove from superview block to use an array map style instead * refactored commit #e4174d51aed804a470b8d42f08229756f8993915 * refactored commit d097f90 - Removed unwanted comments - Added comments to lines needing clarification. - refactored drawPinLabel to accept an argument containing label bounds * Fixed app crash on 6> digit PIN delete - moved subview removal to before didSetDisplay() block * Fixed issue 384 - Added border around active tab on selection - Remove border around inactive tab on selection of other tab * fix crash on wifi option display and set maximum with for navigation drawer (planetdecred#410) * display no transactions text on overview/history pages when appropriate (planetdecred#412) * Pin pass tab fix (planetdecred#414) * Fixed issue 384 - Added border color key/value attribute to password & pin tabs on storyboard - added code to change border width on tab activation * deleted decred_wallet.xcworkspace - deleted decred_wallet.xcworkspace * Updated PIN/Password tab - set PIN & Password tab buttons to custom Button class and checked it can be used in storyboard OK - set the button border color * Fixed issue 384 - Added border color key/value attribute to password & pin tabs on storyboard - added code to change border width on tab activation * deleted decred_wallet.xcworkspace - deleted decred_wallet.xcworkspace * Updated PIN/Password tab - set PIN & Password tab buttons to custom Button class and checked it can be used in storyboard OK - set the button border color * Fixed PIN/Password Tab accessibility - added border to bottom and right or left - created function extending projects Button class to add or remove borders accordingly * refactor * cleanup * Settings page cleanup (planetdecred#418) * remove unused testnet switch, remove save/cancel buttons * cleanup * change Incoming Transaction Notification setting option layout * set compression resistance priority to make label shrink first * delete irrelevant entries from gitignore * correct status for new tx in overview/history, correct pin/pass tab borders (planetdecred#425) * Set password field as first responder (planetdecred#428) * Set password field as first responder * add self on button call * fix typo in comment * Remove dark background when PIN confirm button is clicked (planetdecred#427) * send page refactor and bug fixes (planetdecred#413) * new send page in progress * done with page validations * send refactor complete * cleanup * send confirm - return toproceed * send confirm - return to proceed * more cleanup * move files around * fix send max * ok and view buttons on send success * use single instance of send page to retain view state * don't hide exchange rate label when re-fetching * don't hide usd amount field when re-fetching * correct send amount verification, make amount reduce font size if necessary * resolve send max issues * unset exchange rate value if setting is changed to no exchange rate * punctuate error message * punctuate error message * capitalize exchange rate text in error display, add punctuation * updates to support latest sync changes on dcrlibwallet/master (planetdecred#433) * updates to support latest sync changes on dcrlibwallet/master * ignore sync listener add error * fix network lost/app sleep coincidence * Settings view cleanup (planetdecred#429) * change spend unconfirm fund Text * disable user interaction on wallet log * add copy button to copy wallet log * enable user interaction and disable editing * Remove Show debug messages on settings * refactor settings * hide delete button from settings, undo changes to main.storyboard * undo changes to main.storyboard * correct file paths * fixing file arrangements * move all settings-related files to Features/Settings * remove settings and related vcs from main.storyboard * cleanup settings * show nav back button when settings is opened from splash screen * cleanup wallet log copy function * clean up security menu UI (planetdecred#426) * clean up security menu UI * refactor security menu * configure security menu storyboard * fix project.pbxproj errors with file listings * Remove security menu VC from main storyboard * fix file listing error * Navigation drawer fix (planetdecred#438) * adjust spacing on drawer * clean up nav bar * align syn status label to center * Rename security menu icon and removed redundant background color set * Implement delete wallet function (planetdecred#439) * implement delete wallet function * cleanup modal * correct delete wallet modal title * remove splash logo double tap action * move scrolling focus down to 2/3 of the screen (planetdecred#442) * move scrolling focus to 2/3 of the screen * scroll to bottom only if next row is not already visible * fix send max button to exhibit consistent behaviour (planetdecred#435) * fix send max button to exhibit consistent behaviour * further improvements to send max behaviour * refactor send page to use new dcrlibwallet functions * build after rebase * clear tx summary on amount clear, fix . as amount crash * improve amount validation * ignore max amount values and display error * sync related adjustments from dcrlibwallet/master * re-calculate send max amount if source account is changed * Restore double tap splash screen logo to show settings. Prevent settings crash if wallet is not opened. (planetdecred#447) * restore double tap splash screen logo to show settings * tap gesture on logo region instead of logo * hide wallet options when wallet is not open * hide rescan blockchain and delete wallet option in settings (planetdecred#448) * update project files * Delete wallet fix (planetdecred#444) * invalidate sync timer * fix changes requested * add empty line to differ code * update code to work with dcrlibwallet shutdown wallet fix * Implement Settings -> Rescan Blockchain (planetdecred#445) * implement block rescan * do not treat rescan progress as active sync->rescan progress * do not update nav menu labels during rescan * don't rescan if sync is in progress * allow updating balance during rescan * show delete wallet and rescan blocchain settings options if wallet is opened * Settings: add button to show open source license (planetdecred#450) * License show in settings * add disclosure indicator to button, connection link and fix contraint * fix text wrap and spacing * fix text color and delete generated viewDidLoD comment * dark gray color used for license text * Fixed issue 358 - Fixed bug where app crashed once input went beyond 5 characters by setting maximum characters to 5 - Resolved PIn strength meter issue by toggling its visibility on PIN commit button action. * pin setup view - show as many dots as possible (planetdecred#452) * Use different app display names for testnet and mainnet (planetdecred#453) * Fix mainnet logo on navigation drawer (planetdecred#463) * Overview, history pages: blink for new transactions (planetdecred#464) * overview blink on new txs and incoming tx, history blink on new txs * implement incoming tx notification listener for history * Send page improvements: hide account dropdowns when leaving page, properly handle invalid passphrase error (planetdecred#466) * hide dropdown when leaving send page * send page: show retry dialog on incorrect passphrase * Settings: Use constants for preference keys (planetdecred#465) * Use constants for preference keys * fix changes requested on PR * Renamed variable names * further moving userdefault to settings * fix changes and refactor * add accountHeader file * fix indent * Security: Increase start up password field height and display keyboard on load (planetdecred#467) * Increase password field height and display keyboard on load * resize textfield height and font * restart sync if it stalls for 30 seconds (planetdecred#472) * dont show receive address during wallet restore (planetdecred#473) * dont show receive address during wallet restore * alowing the receive menu content when its the first wallet set up * PR changes and code refactor * refactor work and renaming of functions to be more readable * if else statement * removal of un needed check * hiding the bar items when in sync * security page: restyle tab for pass/pin (planetdecred#469) * Restyle tab for pass/pin * remove white space * remove white space * Add highlighted background on button * clean up and refactor * fix changes requested in PR * fix changes requested in PR * ipod icons stretch fix (planetdecred#474) * update dcrlibwallet GetTransaction method usage (planetdecred#480) * App Localization and Translation(Russia) (planetdecred#470) * Restyle tab for pass/pin * remove white space * remove white space * Internationalize app and extract strings from views(storyboard,xib and cells) * Move and centralize view controller string * Cont: move,format and centralize view controller string * fix crash caused by encoding * Finalize: move,format and centralize view controller string * delete multiple strings files from views and storyboard * fix cliping error on components for localozable screen * link all string UI component to single file, fix cliping components and clean up files * changing the strings to match android,implement russian translation and fix displaced view * delete redundant files * fix text string links * Remove changes meant for a diffrent PR * delete unused string * revert tab color code * delete duplicate string * localize string update from recent PR * Remove developer team from build * Place localized string in struct for easy readability and usage * link all strings from struct to app * fix copyright header and delete unused singleInstance.swift file * fix changes requested * PR changes requested: create UILable for localized string * clean up multiple strings * fix changes requested in PR * fix settings link with localizedkey * Rename incorrectSecurityInfo key * Remove developer team * Remove extra period from UILabel name * fix typo in spelling * fix changes requested on dummy Text and spacing * delete unused controller and storyboard and few string changes * Remove unused code in label extension * Remove devloper team * new wallet->verify seed: fix seed word selection scrambling on page scroll (planetdecred#483) * new wallet->verify seed: fix seed word selection scrambling on page scroll * remove test/dev print code * Seed Verify: Auto scroll up to show confirm button (planetdecred#485) * auto scroll up to show confirm button * show confirm button on scroll end, not before * IPodTouch: Fix chopped off text UI on overview and security page (planetdecred#487) * Fix chopped off UI on overview and security page * fix dropdown image into button * Remove developer team * fix cancel image on button in security page * change device id * delete unused label * change overview device * change line break to truncate tail * don't restart sync due to delayed updates (stalling) if sync was already completed (planetdecred#489) * refactor stalled sync restart code (planetdecred#490) * adopt dcrlibwallet RestartSpvSync method to fix app restart sync issues on a synced wallet (planetdecred#491) * fix crash on ipad when sharing address (planetdecred#494) * fix crash on ipad when sharing address * fix popup view to the right of barButton * fix link to view on mainnet explorer (planetdecred#496) * App translation and string rearrangement: zh (planetdecred#482) * translation: zh * Fix string id changes from master and other changes related to strings * Rearrange all string files according to app launch * Fix syntax error * move localized string into Decred Wallet directory * Rename PasswordDoNotMatch ID * Account details : Fix overlapping text (planetdecred#501) * fix overlapping text on account details * fix overlapping text on key row * App Translation:Pt-br (planetdecred#497) * translation: zh * Fix string id changes from master and other changes related to strings * Rearrange all string files according to app launch * Copy strings from dcrandroid to implement portuguese(Brazil) translation * Fix syntax error * move localized string into Decred Wallet directory * Rename PasswordDoNotMatch ID * App Translation:Vi (planetdecred#498) * translation: zh * Fix string id changes from master and other changes related to strings * Rearrange all string files according to app launch * Fix syntax error * Copy strings from dcrandroid to implement Vietnamese translation * move localized string into Decred Wallet directory * Rename PasswordDoNotMatch ID * App Translation: Spanish (planetdecred#500) * translation: zh * Fix string id changes from master and other changes related to strings * Rearrange all string files according to app launch * Fix syntax error * Copy strings from dcrandroid to implement spanish translation * move localized string into Decred Wallet directory * Rename PasswordDoNotMatch ID * made changes suggested Changes suggested on review of Pull request #2 - Updated Cocoapods - fixed typos - removed unneccesary spaces * Fixed issue 372 - changed maximum Int to LONG_MAX - Moved layer clear block to draw function - remove unneccessary type casting on pin lable to improve performance - changed remove from superview block to use an array map style instead * refactored commit #e4174d51aed804a470b8d42f08229756f8993915 * refactored commit d097f90 - Removed unwanted comments - Added comments to lines needing clarification. - refactored drawPinLabel to accept an argument containing label bounds * Fixed app crash on 6> digit PIN delete - moved subview removal to before didSetDisplay() block * Fixed issue 384 - Added border around active tab on selection - Remove border around inactive tab on selection of other tab * Finished start screen * removed unused variables and strings * switched remote branch * switched remote branch * applied first commit * added files for cherry picking * removed unused variables and strings * create floating label class * 90% done with change password view * password input finished * Finished create wallet flow * wallet create flow ready for review * edit * connected new dashboard * switched branch for rebase of #7 * history page code refactored * made changes as suggested * changing to hotfix-warnings branch * merged with history-cleanup * reverted changes to wallet seupt storyboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #462
