Update receive page #354
Merged
Update receive page #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
song50119
force-pushed
the
update-receive-page
branch
from
d682f9e
to
ad4cbee
Compare
|
generate new address background should white no blue as in the screenshot below Current implementation: |
oshorefueled
suggested changes
Mar 29, 2021
|
Current Implementation The separator under the account selector should extend all the way to the right and left of the card widget. Kindly have a look at the mockup designs for reference. |
oshorefueled
suggested changes
Apr 1, 2021
song50119
force-pushed
the
update-receive-page
branch
from
2117d1d
to
b4ab6d6
Compare
oshorefueled
suggested changes
Apr 5, 2021
song50119
force-pushed
the
update-receive-page
branch
3 times, most recently
from
874603d
to
6781533
Compare
oshorefueled
suggested changes
Apr 13, 2021
song50119
force-pushed
the
update-receive-page
branch
from
6781533
to
946760f
Compare
- change generate address button TextSize to 16 and padding vertical 20 DP - remove unuse minInfo button - change modal cancel button text size to 16 - add SMarginPadding19p5 value to dimensions
- reduce params walletAccountsPopupLayout - add fields to walletAccount to display on each row of walet accounts moda - move wallAcctWidget.Handler into page Handler - pageBackdropLayout layout of background overlay when the popup button generate new address is show, click outside of the generate new address button to hide the button
song50119
force-pushed
the
update-receive-page
branch
from
946760f
to
6c4455c
Compare
- Move on account selector widget to Page common - Move account selector layouts methods from receive page to component
song50119
force-pushed
the
update-receive-page
branch
from
6c4455c
to
b8571a4
Compare
oshorefueled
approved these changes
Apr 15, 2021
song50119
added a commit
to song50119/godcr
that referenced
this pull request
Apr 24, 2022
* correct text size and button dimensions - change generate address button TextSize to 16 and padding vertical 20 DP - remove unused minInfo button - change modal cancel button text size to 16 * Add logo into Qr code * Update account selector - reduce params walletAccountsPopupLayout - add fields to walletAccount to display on each row of wallet accounts modal - pageBackdropLayout layout of background overlay when the popup button generate new address is show, click outside of the generate new address button to hide the button * Retry generate new address when generated address is equal to the old one * Update account selector - Move on account selector widget to page.go - Move account selector layouts methods from receive page to component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #349