Cleanup wallets page & its sub pages #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshorefueled
suggested changes
Jun 30, 2021
ui/decredmaterial/list.go
Outdated
| selectedItem int | ||
| } | ||
|
|
||
| func (t *Theme) NewClickableList(axis layout.Axis) *ClickableList { |
There was a problem hiding this comment.
The name of the file should probably be clickable_list.go so it isn't taken outrightly as the already existing list widget.
|
Menu for watch only wallets isn't easily accessible and properly aligned. Clicking the menu should display it upwards not downwards. Mockup |
oshorefueled
approved these changes
Jul 2, 2021
dreacot
approved these changes
Jul 2, 2021
beansgum
added a commit
to beansgum/godcr
that referenced
this pull request
Aug 17, 2021
Change "Connected to n peer" to "Connected to n peers".
song50119
pushed a commit
to song50119/godcr
that referenced
this pull request
Apr 24, 2022
* Use dcrlibwallet directly in wallets page * Add walletListItem struct for managing wallets and accounts list * Add ClickableList and implement accounts list using ClickableList. * Use one backdrop for all popups * Cleanup account details page * account details: hide staking balances if empty * Hide imported account if empty * Cleanup wallet settings, sign message and stake shuffle pages * Handle watch only wallets click events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes included in this pr: